Comments (7)
The ones that say "mention my name" and "don't mention my name" must be coming from somewhere else besides the new site (that language was used in the old form on the old site). I also wonder if the "null" ones are too. I can add some logic to change "null" to Anonymous, but that return value never came up in testing. I guess I can also map the other two pieces of text to Anonymous, but we should figure out what is generating that data. I don't have access to the AWS database anymore, so I can't see, delete, or fix the data in its raw form.
from kodi-tv.
I don't have access to the AWS database anymore
You have now :)
PayPal: The entries might be from stray PayPal IPNs that arrived late after changing the settings, or from recurring donations that were initially set up like this and now repeat those values every payment. I think we can fix up those that are there now manually, but if more of those crop up and it becomes a steady problem, I'll find a way to fix the values before they enter the DB.
Stripe: All transactions from Stripe came up empty as far as names are concerned. I checked the raw webhooks and client_reference_id
is set to values such as "undefined"
or "nullnull"
(as string). Could this be a problem with the form on the website?
from kodi-tv.
I'll check this weekend. Of course this all worked it staging, so not sure yet if it's just a weird transition issue or something else.
from kodi-tv.
I've just taken a very quick look, my feeling is that there might be a confusion with otForum
vs. forum
variables in the JS
from kodi-tv.
@yol was right. I had changed some variable names at some point and missed a couple references to otForum and then apparently didn't test things again. Bad me. The form is fixed now and was tested locally and in staging. I also got into the AWS DynamoDB and deleted any of the bad references (the null names as well as the "mention my name" ones) and rebuilt the site. Those donations now show an Anonymous. I think that resolves all the issues, but I'll leave this open while we keep an eye on it and confirm in production.
from kodi-tv.
The PayPal issues are still there and I think that "old" donation subscriptions (i.e., that were made on the old site) will just keep their option_values indefinitely. So I've updated the aws scripts to fix them up automatically, see https://github.com/xbmc/aws/commit/e70a9513282a0d23543f6e351b418ebf18ef8198
@Darren-Hill has mentioned that he still receives IPN failure notifications, so I'm going to look into that too once I can log into PayPal. It seems like many are getting successfully delivered to the new address, though.
For the Stripe side of things, I think the fix got rid of the undefined
stuff, but we still get nullnull
quite often. I think #199 should fix that.
I also went through the DynamoDB again and removed all the null
entries and fixed the wrong PayPal entries manually.
from kodi-tv.
I think the issues mentioned here are all resolved, so I'm closing this.
from kodi-tv.
Related Issues (20)
- Include more recent Devcon pictures HOT 2
- Fix typing errors on the home page
- Set a minimum donation amount HOT 6
- Eslint Errors HOT 4
- Where is the full JSONRPC spec or ServiceDescription.json? HOT 2
- Endaoment donation HOT 4
- Limit recent donations HOT 1
- Netlify CMS Limitations/Options HOT 4
- Hero image distortion on blog pages HOT 6
- Jiotv not working with new version HOT 1
- "Essay writing" spam on Kodi blog HOT 10
- Enable Netlify CMS "Open Authoring" feature HOT 7
- Add sentry to sponsors HOT 1
- Forum count shows a zero HOT 2
- Provide download button for Apple Silicon (arm64) HOT 7
- "[CR]" showing in addon descriptions
- Add OSUOSL to sponsors HOT 5
- Admin login sometimes doesn't connect with github HOT 4
- CRT shader HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kodi-tv.