Eslint Errors

[krishna8421]

Eslint Errors

[razzeee]

I think turning off the rules is worse then showing them, like this you can at least get the feedback if you choose to. Otherwise you won't even see it.

I'm a big opponent of husky/git hooks. They are always problematic in my experience.

[krishna8421]

I am not saying to turn off the rules permanently, Just muting them for the git flow to work fine and then work on them, because fixing thousands of linting err are much harder, better to fix them one by one.

and husky won't be a problem just a simple bash script to check prettier and eslint before committing codes

I also have some doubt:

kodi-tv/scripts/addon-parser/app.js
225:22 error 'addonstatspath' is not defined no-undef
253:9 error 'cat' is not defined no-undef
282:3 error 'newauthor' is not defined no-undef
283:3 error 'authorcheck' is not defined no-undef
301:48 error 'newcategory' is not defined no-undef
307:7 error 'categorycheck' is not defined no-undef
and some more....

Are these on purpose??

and

by-paypal.tsx

var value = target.value;

this var is also giving a linting err, is this on purpose

I made some changes Check it out github.com/krishna8421/kodi-tv

[razzeee]

and husky won't be a problem just a simple bash script to check prettier and eslint before committing codes

which means you have to wait for the compile/check on commit, which is annoying/ breaking everybodys flow
you also can't do WIP commits anymore, as you need to fix everything to be able to commit/push

[krishna8421]

Husky doesn't start automatically, you have to run

npm run prepare

else it will act as normal.

In my opinion, it is good to check if the files are ready to commit and the build is successful.

I will make a pull request in few mins please check it and delete the things you don't like.