[Linux - webserver] xbmc ignores posix CAPABILITIES for non root user

[s7mx1]

[Linux - webserver] xbmc ignores posix CAPABILITIES for non root user

[s7mx1]

--- a/xbmc/Application.cpp.orig 2012-05-25 12:10:36.000000000 +0100
+++ b/xbmc/Application.cpp  2012-05-25 12:16:12.000000000 +0100
@@ -1321,13 +1321,6 @@
   {
     int webPort = atoi(g_guiSettings.GetString("services.webserverport"));
     CLog::Log(LOGNOTICE, "Webserver: Starting...");
-#ifdef _LINUX
-    if (webPort < 1024 && geteuid() != 0)
-    {
-        CLog::Log(LOGERROR, "Cannot start Web Server as port is smaller than 1024 and user is not root");
-        return false;
-    }
-#endif

     bool started = false;
     if (m_WebServer.Start(webPort, g_guiSettings.GetString("services.webserverusername"), g_guiSettings.GetString("services.webserverpassword")))
@@ -1345,6 +1338,16 @@
       CZeroconf::GetInstance()->PublishService("servers.jsonrpc-http", "_xbmc-jsonrpc-h._tcp", g_infoManager.GetLabel(SYSTEM_FRIENDLY_NAME), webPort, txt);
 #endif
     }
+    else
+    {
+      #ifdef _LINUX
+      if (webPort < 1024 && geteuid() != 0)
+      {
+        CLog::Log(LOGERROR, "Cannot start Web Server as port is smaller than 1024 and user is not root");
+        started = false;
+      }
+      #endif
+    }
 #ifdef HAS_HTTPAPI
     if (g_settings.m_HttpApiBroadcastLevel >= 1)
       getApplicationMessenger().HttpApi("broadcastlevel; StartUp;1");

[s7mx1]

Tested it against with the latest xbmc-rbp

[bobo1on1]

The patch looks ok to me.

[bobo1on1]

#1015

[bobo1on1]

Fixed ccb09ba

[s7mx1]

bobo,

Thanks for your great work.
On May 31, 2012 11:46 PM, "bobo1on1" <
[email protected]>
wrote:

Fixed
ccb09ba

---

Reply to this email directly or view it on GitHub:
#1012 (comment)