Choose dialog for versions added to favorites / No Choose dialog for movies added to favorites

[CrystalP]

Choose dialog for versions added to favorites / No Choose dialog for movies added to favorites

[ksooo]

Choose dialog if "Show versions as folder" is OFF, browse into the versions if "Show versions as folder" is ON.

The action to execute is stored along with the favourite. That's the concept of the favourites to define an action that is to be executed on an item. Making the action dynamic, depending on a settings value for example, is imo much effort and I think this edge case is not worth to invest the time the implementation would take.

[CrystalP]

I'm not familiar with the code. The way you explain it, this could be addressed in the "Add as favourite" actions, maybe something is not stored as it's supposed to? the isfolder attribute maybe?

But I'll agree that not showing the Choose dialog for a favorited version would be more impactful.

[ksooo]

The way you explain it, this could be addressed in the "Add as favourite" actions

That is what currently happens. If the setting is ON, a favourite for browsing the versions will be created. If it is OFF a favourite to play one of the movie versions (choose version dialog or play the default version if the respective setting is on) will be created. But once the favourite is created, changing the setting value has no effect on the behaviour of the favourite.

[CrystalP]

I'll test a bit more, I wasn't aware of that. Sounds reasonable.

[CrystalP]

Confirmed it does what you wrote and remembers the browse/choose action from the time the item is added to the favorites (except for individual versions)