xcir/libvmod-xcounter

libvmod-xcounter's Issues

Versioning scheme

The current versioning scheme seems a bit out of line (compared to other VMODs).

For example, last release v61.2 works just fine with Varnish 6.0, not only with Varnish 6.1.

So I think it is better to stick to simple versioning like 1.0.0 that does not depend on Varnish version. The Varnish compatibility info in the README.md file is enough.

Thanks for your great work :)

Build error on Rocky Linux 8

Hi, I am trying to build vmod-xcounter on Rocky Linux 8 for Varnish 7.3 and I am getting error when running ./autogen.sh:

+ aclocal -I m4 -I /usr/share/aclocal
+ libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
+ autoheader
+ automake --add-missing --copy --foreign
configure.ac:11: installing 'build-aux/compile'
configure.ac:9: installing 'build-aux/missing'
src/Makefile.am: installing 'build-aux/depcomp'
+ autoconf
configure.ac:16: error: possibly undefined macro: AC_MSG_ERROR
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

Varnish is installed from this repo and varnish-devel is also installed. Are there any requirements I am missing?

Memory leak in vmod_vsc__init

When hidecold is false ds is lost track of. This was spotted by clang's scan-build with scan-build make.

libvmod-xcounter/src/vmod_xcounter.c

Lines 225 to 232 in 8aebc77

	struct vsc_xcnt_seg_head *dsh;
	struct vsc_xcnt_seg *ds;
	CAST_OBJ_NOTNULL(dsh, priv->priv, VSC_XCNT_SEG_HEAD_MAGIC);
	ALLOC_OBJ(ds, VSC_XCNT_SEG_MAGIC);
	ds->vsc_vsc = xcntvsc;
	if(hidecold) VTAILQ_INSERT_HEAD(&dsh->vsc_segs, ds, list);
	}