xdevplatform/cards-player-samples

Sample Code for Player Cards, both for stored and streamed video.

cards-player-samples's Issues

No display, only comments !

Hello,

Maybe I missed something, but I set everything, and nothing, only the three comments :

_This page has meta tags showcasing the Twitter Player Card with a static MP4 file. The video is courtesy of @twitterdev.

When implemented on your own site, please ensure that all links to video are secure (use https).

Lastly, the behavior of video playback is according to the following rules: https://developer.twitter.com/en/docs/tweets/optimize-with-cards/overview/player-card_

Need help please !

Should use example.com instead

Since yoursite[.]com actually exists, we should use example.com instead.

Now on Twitter, you don't seem to need your domain approved to display player cards.
When I tried deploying without thinking too much, something like yoursite[.]com refused to connect. was displayed on the card.
I guess it's not good to use an existing domain for example purposes.

Update screenshot to show a current Player card

Add support for svg images

Please add support for this image extension (.SVG)

In the following page says that SVG is not supported:
https://developer.twitter.com/en/docs/tweets/optimize-with-cards/overview/summary-card-with-large-image.html

This framework is fundamentally flawed: only allows one card per html page

The very essence of this whole card thing is pathetically flawed, in that one has to define the contents of a card by unique metatags in a page, meaning that one page can only contain one card.

Suppose that I have a webpage with a few posts (e.g. each post having an image, or a video).
An url like https://mydomain.com/path/to/some/page#post1 would point to a post and an url like https://mydomain.com/path/to/some/page#post2 would point to another post in the same page. Your "Cards" system doesn't allow to define a card for post1 and another card for post2, having each link work as a different card.

Autoplay directly in Twitter

Is there a way to get autoplay working directly in the feed without having to click play? I'd like to use it as an animated og image.
My current code looks like this:

    <video muted autoplay loop controls>
      <source src="sanshoOgVideo.mp4" type="video/mp4">
    Your browser does not support video
    </video>

File name in README.md

The second step in the quick start is:

Open the index.html file and

However there is no index.html file under /player. Did you mean player/page.html, or should that be renamed to player/index.html?

Not whitelisted issue

Hi i am using this sample code and make all required changes as suggested in help doc. But i am getting Not whitelisted issue when i am testing it with validator. Can you please guide me what i have to do. Please see the attached and https://twitter.ethrmusic.com/player/page.html is url to my card.

Also i want to know if i want multiple card than what i have to do? need to create new html file for every card or something else please suggest ASAP. Thanks in advance