Giter Site home page Giter Site logo

gladdy-tbc's People

Contributors

xiconqoo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

gladdy-tbc's Issues

Green Health Bars

Add a Healthbars green or green to red option.

Is there a way to make health bars green? You can even tell me where to modify the code if theres no option for it wich i haven't found, or there's no plans to make it as an option. Great addon, thanks for making it and keeping it updated!

Controlling Text on Individual Modules

Hello,

I'd like to be able to:

  • Turn countdown text on and off on the various modules individually of one another.
  • Choose timer format for each module individually of one another.

E.g: No countdown text on DRs/Trinket/Racials/Buffs&Debuffs, but have countdown text on Auras and Cooldowns. All controlled individually.

Maybe I've misunderstood something and this functionality already exists - but I don't think so.

Grouping of Modules

Make modules like ClassIcon etc be able to group to itself to achive a layout as such:
image

Highlight > Border Size - option to be INSET, not OUTSIDE the frame

``Hi there,

I'm trying to create a look that is identical to Blizzard Raid Frames.
https://ibb.co/F86tBCN

Issues:

  1. In /gladdy ui, settings > Highlight > Border Size is set to 4, but the space it occupies is around the frame, unlike in Blizzard Raid Frames that has 'INSET' border, and it actually occupies space inside the frame itself. Is there any way to make this work?

  2. Minor issue, on the screenshot you see where it say 'Gladdy - drag to move', it is actually larger than the frames themselves, and that left part is 'empty', and it makes Blizzard Raid Frames not clickable in that part.

Here is my Export:
4XzRB1TKtRKd(jIP6)72xsagGQoaZsMtTNtvub8K4zswsIN12zHHl4zFv3sT)lXXgo5gIhB1sQLul9jzZc(IBxm)Ud3FF5m))82L57VjD1Qn7FyX75lMVmpF7Q8VTFwEXQSIxKVnVWVG0WdVl8ViHf()TQnRE(2hxJ0TmTSAwAXX8Gf4blWdwGhmppwbeHITHhfPl3KU947V)XBlY2LxCD((Q)(dGyZQc8AvXl3uME32SxSPy52Sf31Ogp0sfUwlsS8eT1yzsBIwS4(NPLNwTQk2S)RzvhXxu1E1E)Dx5VXJzvVjlDB1AqAVjBZdRbvYWc6AEv2UB2MwLHMNNV9BPpvEBAXdzv4Ad2V5RZ)2ZpuK(YSWF2iKBYlxm)JV91V5w)o8FVzv16RtxwLhS(Zxhf6TzFV6qr2I5Z2U5h)iTy1p)Yht3a)l8SwQ3nzflZ2xL(q2Iz1BVH80hzowdBSTHnxuTJENGwE7hUPLgHc07KMV5hzapfTdvIl81f5F7LBkYwwTjFF9gLmBbvQ0Rtv()uALo)FSCCnnfJwyxzwmpJCtZcEupJ4AoZEr4KJBhIrxLiqEDLp6AAStYSmZfsXsyxgg5K6lcJmQKldJ4m9fItAzI6IWiNqCzINek3qA0v6y4eYm43rzNuAmYlII54dQy)AmsBSxgNNqNWUmPdCC1qgPR4KrpPPE3imJz5xeTsBLxOtWAi17aBpinylEDvIzC2j1jjxg9IBVqBqU7YyYLIe3qMQFnoXndN)9kUPtqL3l4gNLqG1L5GJJBUm1y46)XLgQ6cNBX8xMxSP8gahrQhmuFCxaoM2i(808hBkREz29Ph2w5vbJfdQAeY8hl2amT6PfVxf0fHJozDsA4H0QCHuRhHpCMetaDoACkXW8bLLe8h8r5JrpMSKCHqnincIgo3oI(isOaKttdQpjAMCmDwRCJkllZn8(sI8XKytgJgHJnmnKF3K4gJpcMwngFKszYW(usFS2HnHK5roAuOlXnSroQWjd7ZrbPjmfNHeLIPg2vfnXIeXyhByQHfvDKJDyrHQJZOgn4s4eJzHDGkpMVuzoZMcpZaOdgn2IZe2HJJXDUqlSJ5ieq6IHLfLVqPsglYryfIrnHoyZpMd1PsoZ(cPjr6gZvyyJLnvluNjPJMsemQdvitedBC0OOSUXyJukyJLdukTJVVLJM2wPvYHPbdbnQXcsfc9Of(syJ6fKmXzs5epwDMqDsBySZucjg(jhrsvXbg0mFI3UB3H9z(L1cpfGhfXtXenO0Pr)GOka9bEu7H0upVK57YZRwdpm)BzfTgpYD1tHOSEAh9N(YQI)QfAK(6615f76QPDWAhG8TCBAzycCtEszXXZ1hheYG5vpbiLM)29vzf3NUm7tpF1QpSV8tVEB6Qvp9P3Ud2ALFcP9Zf5h2VkB1NVB7JDSxnZRzvr)Pd2Ft6Nz1yBYwR5xs)k)VhslI6xW)qk4egkz035NR2R2NT7Pa8Xw8G2KER3(9GHyz2oWZJdBchl2hZsxfww5Jzl9)Mf5drWFwMfgGhoYl)vRYkbzxMT9EqtYkpuqd2Q0hDVYVQWv4cUDnqYAWBgp1euV3L(DpN(FzfLWc)8U0)tEXN3FyhU7cJeShs5vfViTk7b4pZcQF52SSh7DY6(CiW27l98EJ)33ZLgwcgsvvSTS6W(PSgDIr6xtX(vtEjodkM1P4bIXwGXN7fwWxlNc1aSKquw5Y0kiQAARbADXVMvBk9MT9vtzrgFN9(fTCsuZvHIw3NLwmf6fCEyBuaPJMc9ANYroIFHLiclj7rFsoiKFsRkbx1QI0hGi57kYsHG9jSqfzKpKofQ1jw0EvKL9JSQI0jfcRDsLFvB29iCNj5yQdhFA5289tYey4bDlODP7YGCLBZ6DES5EHSD)9zQlu(QgXTU)u5VZRclpq07jbLrNspHjhupODkZAiFwy6GDEPd)g5D7ux4Uu8LoemD1LjI3kPV4q1akFxNST(1HuV4B3SlluDmfSO)XRU(wFWvRxMsZBjOFbxiSy5xZwfFjjWcDmat3mpaCBI1FbKoaqq7VJdal6VH0aTibxy9WuHF9D2pZJc0ewPibA2WtF8xaco3Frctgi0F20fyqGFHUk8RdoWgwGnbVHMldKrphHf7LxuGEeU()MffucpOycMf1eghVqQqg5ri5)vlqozSohYbPcjWpDHzr0F(7WdeYnAEypiCwKvGYHph)Zq77EojiL0irLsQybRNlreyqOr2WMWQcIYfLTg6NM2NmdjBCBOmkuz0AlQf6KKaTkoPWi2z4cTl8aJJ4LF6WWfwgzdb3z4cjy2XTSWeOiaMninUe1ubkur0CRLrRkkkeuQFPo0khMfsyjoCtRf4V4KlMfAe1s3GHxKO4ixDOL0ZD0Ea6fErscUhayYwCrsk20GgDHrAP9IaVrInSuD09bbZiHg8clUqSJn4cfliC4POKmuiih2i1bZbwAGSxijoDqO6yKIqIc3PXvaHqORWI(cYJHpfS2HvdfbXvB50zJOrwGeAzOrGJ33APFWJmqR)yablHmA2ekuxrxWnbkKmoUhXoIrwAO4mogmlusIn45eOPxmiMoWd5gOfiOJv(gNNrDLfeVGyaQFHjLmJAq0F7e60dToGA6al3f2(gmg0YjJI0eEUKtH1WHeussjzBrfYYPqfIpCHQ2Geo3vf6wjMLL1kD6KBuyvr36sT7(PDjJeS)HJFp7ek3MoO(5xM5rRgFWXLK6xPB6q0V2JcB12a6AaZ)EqDoSVYRpOskapjvXJai)qr(3(ZhRr17zYhHcB(BqLzM)yAXxBvwzvXVrTWxVnVSmk6NVS6q62GiiRvlXnXgtAkB)qhN4vQZ3Vx7gzJ3RFZzE)yVgEVjVakAUP63yR3bgqWi3S)Bp0(MoPilr7pzHOQcEnV2wcqD(Jn7j6dXlD8qD(EciweOQ92ABUheG)4YQtCCya7oPB1nS)mR84a2xCOOm7e8j2oRPUD2b(KqqBHRgA4)uZoDulEiOXEEQxns9X7jgkwf(iuAqA22P2EWg(5XOfxXnW)QzkMXTy(3xCTtBuqEFgdsmB9fQU)zq6r8f3eaOD(VReEtmEF3WnRFQCdK4ASblu5B3EwJr53WAtNVVlVQkF37adYM9TaTF0N4YSpC7TF4DTFCBK(T9btyBhpU69Un5PB7voIjxB0sfGvZc)it0q5o8JxkY4RDqnqO)zLwPbmbasOWZjHnBuNc7ejQMy0uyZJq9fOTOogsZAn3Qo2XOj48wlEt9StKARv7ud95w5pGSnlf24NV8z)yYZ)vkv)5q1UCQQPu9iFtwXc69Qdyr95kjnut6Jh6QGxKYhCYML(RbIeNyHMo(7OzMA4AwSDlaUhcHr4rSfWkPfecgedMdbGcXOuFdUeSBkteqAS7hlUsrc2gf3qnbieewFarnYBeljaH1qO1WgoS4cruHwccnXDgIEe0guDbeCi8xQHcn2jLwIi(GEYiiFooboxzrwznuhukReLGJq1Jq8GJJKwRIAnIXfwiIDgTyAb2Tb06dUIWC09CiHjqLb7tbmLiCuKEHYrOvH(xcgcLH0qYwl5guv1cSHdbxBeOSeuVzG1g7sYWXDoyePwAui(AH0gbARerG2OXYNVHAHg7ltyDieC8Lx4P1H9HdLiC1B)WfgQJaYmYrEBWEVQAvEV3iuADsfk2LL2RWmf)6JMBkn)yNJgDqh0EQlD(6uBn4KvfV)W2Tti34JrqxNy8oVl9Hnlpfgc)3(qqvfiUocGRxH6cUNkG9E)0PorknIvuQGJXT3g(7eYBJavg6tN91hYklZctTMe4jHMnH83iSPN2NUBZsK8zTE)hOxaoFt5HEF6USwUQJleQ1C4yJXWeqVPs4WpuOl8fYDne3bnrj1AOlph0ApvIShqqVqNqxuTRAuNUTrHLSEvkACdhbQjFtz((tgdB6312emNDJHBhXCCJENpIMK7Bs3E)eKBt9MUwH29Pmb20Q5YMZ9RkAJMkYXteH3swnRULJTDm66(Fx2ABhAjS1Iwu6d(A1zd)yDjumeFj7HmZ0aEK8eCMH430J)cMJOjoKP6Hl5NrcsSchwxC6ahviKlIJmm8Xt4VOE2smCKeq5wgnvlhnqkjrI0jT0QJtKKt1QIJKKZCjunwoDrIMMhOIgcjChQWrCkvolvKLPQvtA0OyTr8lsYFJWNuuqPsyDNaj3Iprk0QUL5QlKghweuGIM1RWwp)Mi6dlvWZHtdeCaKvwj5XkFKKIJbck6tZHrrZHryC0GBQltQ4KHwehRNm6iTjcQMwSozSCRJW0upYX66KgvCWMgk0rsgrQgU0OXATcJHgWAy6vWzMYQ0QdL3fpvhpQyx09d5)xQ)NJBY3pjL5(345SUht(v4k1vv8uZrVL8MJYRhot1azKX6v)1jsu0)Tf0Uf8jLc8FDiTO6m06XM3PDNwiMBEP51106mhe0sgZb1HU(6DTzlWa8fK0(vxxpgi61P0VnJ4oVtYuK26B9mURh2IJ)4gALG3051sneQIGXeQ)QfqT3eM0WGdHI6wq7HYPb31D9BFPUk7P(pMutnhCB(89lxdQt8qWI(Fuf)srUDpp0Zh36LU3)TVD(cW0Jrj(ZVClStQ284p)sqAGPzX)))3a)wx

Arena Enemy target Icon/Bar

Much like the gladius feature it would be useful if we were able to visually see who enemy targets were actively targeting.

New Module Idea: Totem Tick Bar

Hi
RMO here.

The idea is this:
A custom bar which would inculde all of the enemy ticking totems in one bar.
(or into seperate bars, arena 1-5)
I know that we already have this in the nameplate icons,
but I have to constantly watch the totems position to track tem.
This would solve that problem.

Basically the test mode just with more icons.

[Enhancement] DR Level Text Indication

See: #15 for details.

Since the ticket was closed for workflow reasons I'm re-opening it as an issue ticket instead.

Do you have an ETA?

Thanks in advance!

Best Regards,
ManneN

TotemPlates / TotemPulse offset options

Would it be possible to get the ability to move the totem icons + pulse bar/text position please? Thanks!

I noticed that the icons and pulse are aligned and tied to the nameplate/clickable area of the nameplate yes.
Personally i use threatplates for the totem icons and disable gladdys totem icons but i leave the pulse timer on. The main reason is threatplates elevates the icons position above the clickable area which can make them far easier to spot when there is a crowd of nameplates/icons in my experience. Its not a huge deal to be able to move the totem icons + pulse timer text but it would be nice for increased visibility/for cases like mine.

Totem health

A number at the bottom of the icon which represents the actual HP.
Underneath the icon would be the actual HP.
It would be a good idea for an option to set the Name / HP / Totem Name position.

image

DR timer not accurate?

Sometimes DR timer shows finished in arena, but the spell is still diminished... \

Could there be some kind of latency or other reason for it showing DR timer complete but the spell is still diminished.?

Bugs out nameplates

When I have gladdy enabled, I sporadically have enemy nameplates become grey translucent bars with no text and are near invisible

TotemPlates causes ElvUI nameplates to not show

With update 2.11-Release a new bug has been introduced where Nameplates are not showing for certain mobs and other players when using ElvUI Nameplates and Gladdy. From testing and other people reporting same issue in the ElvUI support discord channel, we've found that Gladdy TotemPlates is the cause of issue here. When disabling TotemPlates the issue is gone and all ElvUI Nameplates are shown correctly.
Could you verify @DnB_Junkee? :)

[Version: 1.19-Beta]: I got these errors after game start, used Invisibility before gate open

4x Gladdy\Modules\Racial.lua:180: attempt to index field '?' (a nil value)
[string "@Gladdy\Modules\Racial.lua"]:180: in function '?'
[string "@Gladdy\Gladdy-4.lua"]:130: in function 'Call'
[string "@Gladdy\Gladdy-4.lua"]:135: in function 'SendMessage'
[string "@Gladdy\EventListener.lua"]:58: in function 'SpotEnemy'
[string "@Gladdy\EventListener.lua"]:142: in function '?'
[string "@Gladdy\EventListener.lua"]:25: in function <Gladdy\EventListener.lua:24

4x Gladdy\EventListener.lua:67: Usage: UnitIsUnit("unit", "otherUnit")
[string "=[C]:"]: ?
[string "@Gladdy\EventListener.lua"]:67: in function 'SpotEnemy'
[string "@Gladdy\Modules\Healthbar.lua"]:127: in function <Gladdy\Modules\Healthbar.lua:97>

The latest release is not available

The link to the 1.12-Beta release returns a page that just says "Not Found". The latest release I can seem to find on github is 1.10-Beta.

[Bug?] Gladdy click action not saving

Version: Gladdy TBC Classic V2.11
Localization: zh_CN
Description:
Each time I try to assign click skill / macro inside the Clicks tab, it returns blank when I switch to other tabs or close Gladdy setting windows.
Help needed. Thx

Feature Request: Range Check fadeout instead of darken

Could you add an option to the range check module to fade out the opacity of the bars instead of darkening them?
I find that a much more intuitive way to recognize someone is out of my range than the bar being a darker shade (plus my unit frames addon does that with friendly players already).
It's only really necessary in 5s where you lose track of enemies in the mess, but it'd be a great help.

Feature Request: Exact Spec Detection

Hi

RMO here.

Is it possible to modify the Spec Detection system?

Take look this picture for example:
image

This is how I see the enemies when the Gates are opened.
I can only see 4 enemies but 1 is missing.
But I can also see that one of the enemy has the "Gift of the Wild". (on the Paladin)
This mean that he is with a druid (arena4) and Gladdy should do a druid colored namefreme to arena4,
and also since he has the "Leader of the Pack" buff it should indicate that that is a feral druid.

I know that there are some restictions here.
For Example if there are 3 stealthed enemies, then this would not work since the addon has no way of knowing which enemies correspond to the certain 'Arenaframe'
When this scenario Occurs then Gladdy should not do this feature.

grow up set position not working correctly

Anyone have any thoughts on why the location of my gladdy frame gets reset upon entering an arena and/or locking the frame? Only happens when I have grow set to "up" versus the default setting of down.

Move Auras and detach from Class Icon

Hi there,

First of all, thank you very much for previous enhancement to make Gladdy look more like Blizzzard Raid Frames.

I have an additional feature request:

  • Option to detach Auras from Class Icon and move to middle of the frame
  • (and / or ) Option to disable Class Icon

Screenshot:
https://ibb.co/khfhMJP

(on the raid frames the icon in the middle is from Lose Control addon)

Error after Arena ends - TBC Gladdy

Message: Interface\AddOns\Gladdy\Modules\Cooldowns.lua:466: attempt to index local 'icon' (a nil value)
Time: Sat Feb 19 19:12:10 2022
Count: 1
Stack: Interface\AddOns\Gladdy\Modules\Cooldowns.lua:466: attempt to index local 'icon' (a nil value)
[string "=[C]"]: ?
[string "@interface\AddOns\Gladdy\Modules\Cooldowns.lua"]:466: in function UpdateCooldowns'
[string "@interface\AddOns\Gladdy\Modules\Cooldowns.lua"]:271: in function ?'
[string "@interface\AddOns\Gladdy\Gladdy.lua"]:174: in function Call'
[string "@interface\AddOns\Gladdy\Gladdy.lua"]:179: in function SendMessage'
[string "@interface\AddOns\Gladdy\EventListener.lua"]:73: in function SpotEnemy'
[string "@interface\AddOns\Gladdy\EventListener.lua"]:41: in function ?'
[string "@interface\AddOns\Gladdy\Gladdy.lua"]:174: in function Call'
[string "@interface\AddOns\Gladdy\Gladdy.lua"]:179: in function SendMessage'
[string "@interface\AddOns\Gladdy\Gladdy.lua"]:528: in function JoinedArena'
[string "@interface\AddOns\Gladdy\Gladdy.lua"]:423: in function ?'
[string "@interface\AddOns\Gladdy\Gladdy.lua"]:120: in function <Interface\AddOns\Gladdy\Gladdy.lua:106>

EventListener lua errors when in Bg

1x Gladdy\EventListener.lua:72: Usage: UnitIsUnit("unit", "otherUnit")
[string "=[C]"]: ?
[string "@Gladdy\EventListener.lua"]:72: in function `SpotEnemy'
[string "@Gladdy\Modules\Healthbar.lua"]:127: in function <Gladdy\Modules\Healthbar.lua:97>

Locals:
(*temporary) = "arena2"
(*temporary) = nil

I wanna activate the Gladdy-TBC in game

Please help me~!
I want use this addon in game.
I had installed and tested (/gladdy ui /gladdy test). It was good.
But the addon is not activated in arena.
I don't know why.

Next items are my addons list. Please let me know any crash list.

Atlas (Battlegrounds, Burningcrusade, ClassicWow, DungeonLos)
AtlasLootClassic
AtlasQuest
Auctionator
Bagnon
Bigwigs
Capping
DBM
Details
dgks (DG Kill Shot)
Dominos
ExtendedCharacterStats
FindParty
GearScoreLite
GTFO
Itemrack
LittleWigs
Mapster
MoosiAlert
NameplateCooldowns
Omnibar
OmniCC
OmniCD
Plater
Prat-3.0
Questie
SexyMap
SilverEyes
ThreatClassic2
TitanClassic
TomTom
TrinketMenu
VendorPrice
WeakAuras
ZPerl

Gladdy - OmniCC support

Suggestion

Add OmniCC support or create an option to modify the current one.
Personally I do not enjoy decimals on cooldown text.

The addon is amazing btw, keep up the good work.

Feature Request: Castbar title placement

Hi

RMO here.

Could you add a vertical and horizontal text replacement for the castbars.
Also make an option for text allignement options (Left-Alligned, Right-Aligned, Center-Aligned)

image

Feature Request: DR Texts and Border Colors

Hi

RMO here.

So I have a cool DR coloring idea.
Right now this is how it looks like at my end.
image

I can see the DR timers on the Icons with yellow color and underneath I can see the DR levels.
Anyway I've made some modifications
50 = 1/2
25 = 1/4
ร˜ = Immune
(just so you can understand)

But can you merge this together?
Like this:
image
(Epic Paint Skillz)

So that I can see the DR levels on the actual Timers and therefore we dont need to use two timers on one Icons.

1.20 fails to show frames in arena, 1.19-beta works fine

Updated to 1.20, didn't work, reverted back to 1.19-beta, and it works fine.

This is the lua error i kept getting trying /gladdy test3, and any time entering an arena.

Message: Interface\AddOns\Gladdy\Gladdy.lua:466: attempt to index global 'ArenaEnemyFrames' (a nil value)
Time: Wed Sep 15 18:03:06 2021
Count: 1
Stack: Interface\AddOns\Gladdy\Gladdy.lua:466: attempt to index global 'ArenaEnemyFrames' (a nil value)
[string "=[C]"]: ?
[string "@Interface\AddOns\Gladdy\Gladdy.lua"]:466: in function `BlizzArenaSetAlpha'
[string "@Interface\AddOns\Gladdy\Gladdy.lua"]:233: in function `OnInitialize'
[string "@Interface\AddOns\Gladdy\Gladdy.lua"]:71: in function <Interface\AddOns\Gladdy\Gladdy.lua:69>

Locals: 

Using elvui, dbm, details, plater, wa etc basics.
Tried turning different things off, didn't help, same error.

Original author statement

Hi. I've been looking for an arena addon for tbc classic and stumbled upon Gladdy.
I was quite suprised to see Schaka as original author. He took Gladdy long years ago when I stopped supporting it.

I was inspired by Gladius and tried to make something similar for TBC private servers. So I took ideas from Gladius and Proximo.
Here my repo https://github.com/miraage/gladdy, which Schaka forked at some point https://github.com/Schaka/gladdy

Part of me would like to be mentioned, another part thinks it doesnt matter much.

Off-topic: if you need some help understanding the codebase and maybe fix a thing or two - ping me on Discord osher#5008

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.