xivapi/xivapi-py

An asynchronous Python client for XIVAPI

xivapi-py's Issues

Private key shown in loggings

Hello!

Well, I know there is clearly ways to work around this, but it's not really safe in my opinion to print out the private key in the logs.

I know. I can change the logging level to something higher than info for the module, but I just don't think, in any cases, the key should be printed in any type of loggings (maybe debug)

Talking about debug. I don't think a query should be logged at the "info" level but the "debug"
INFO:pyxivapi.client:200 from https://xivapi.com/search?language=en&private_key=

loop is not defined

I could not figure out how to run the example file.

Error: name 'loop' is not defined

I fixed this issue by adding:
loop = asyncio.get_event_loop()

Character Bio Not Updating

Heya, I'm not sure if this issue has been created posted (and solved) already, but I've tried multiple times to get the character bio section from the lodestone to update through your API calls (both REST/GET requests as well as the python library itself) but no matter what the data stays stale. IDK if there's some sort of caching or timeout going on where updates only occur at certain intervals, but your documentation suggests "real-time" which is why I'm a bit confused. I hope this is just something I've overlooked in the docs and not a huge technical issue for you guys.

XIVAPIClient.index_search() raises XIVAPIError with any wildcard query

Don't know if this repo is maintained anymore but thought I'd mention an error I ran into!

Passing any query to XIVAPIClient.index_search() with string_algo="wildcard" raises an XIVAPIError exception.

This occurs because the "wildcard" query type does not support the "query" parameter, as explained by the response.

{'Error': True, 
'Subject':` 'XIVAPI ERROR', 
'Note': 'Get on discord: https://discord.gg/MFFVHWC', 
'Message': 'Search Error: {
    "error":{
        "root_cause":[{
            "type":"parsing_exception",
            "reason":"[wildcard] query does not support [query]","line":1,"col":69
        }],
        "type":"parsing_exception",
        "reason":"[wildcard] query does not support [query]",
        "line":1,"col":69
    },
"status":400
}', 
'Hash': '61969353bd46e810ce74ee1177e0d79b0c1bf5f2', 
'Ex': 'App\\Common\\Exceptions\\SearchException', 
'ExCode': 500, 
'Url': '', 
'Debug': {
    'ID': 'Yn60aZfP21081602', 
    'File': '#55 xivapi.com/src/Controller/SearchController.php', 
    'Method': 'POST', 
    'Path': '/search', 
    'Action': 'App\\Controller\\SearchController::search', 
    'Code': 500, 
    'Date': '2021-08-16 14:10:10', 
    'Env': 'prod'
}
}`

This can be fixed by ensuring "wildcard" queries are constructed with the correct parameters like the following:

'wildcard': {
                NameCombined_en: {
                "value": name,
                "boost": 1.0,
                "rewrite": "constant_score"
                }
            }