xotl/cool-github-releases

cool-github-releases's Issues

Input Repository

First of all, this project is really well done. Thank you for publishing it.

I'm wondering if you have any plans to add an input option to specify a separate git repository to download release files from, for instance in the form repo:Xotl/cool-github-releases.

For me, I manage a utils repository separate from my main app, and need a way to download those assets to my main project when building. This would be the perfect solution if I can pass a different private repo.

Given the way you've set up the action, it seems possible. I'm happy to help out.

Need a way to update existing assets

This action is fantastic, it may revolutionize my ability to give users access to pre-release versions of my software, building assets and attaching them to the relevant pre-release on GitHub, as well as passing assets from one job to another (for example to build installers for different platforms).

However, I need a way for the update action to replace an asset if it already exists, because for every push the pre-release build assets need to be replaced by new versions. Is this possible to add? Right now the action fails when it finds the asset already there. That is a reasonable default for most use cases, but I need a way to override it for mine.

Deprecated API authentication via URL query

Using the current version of this action in download mode is deprecated for personal access token authorization, this is in the case of downloading assets from another repository or in general replacing the scoped github.token with a personal access token.
The following email is delivered to the associated account when the request is made:

[GitHub API] Deprecation notice for authentication via URL query parameters

On *** at *** (UTC) your personal access token (***) using node-fetch/1.0 (+https://github.com/bitinn/node-fetch) was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/***/releases/assets/***

Please use the Authorization HTTP header instead, as using the `access_token` query parameter is deprecated. If this token is being used by an app you don't have control over, be aware that it may stop working as a result of this deprecation.

Depending on your API usage, we'll be sending you this email reminder on a monthly basis for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param for more information about suggested workarounds and removal dates.

Thanks,
The GitHub Team

This is due to the use of node-fetch call in these lines.

I believe the workaround is simple enough and will fork, test and PR once I arrive at a fix. Making sure this issues is tracked here including all work that may currently be going into a solution.

Allow assets to include wild cards or glob patterns

My outputs from a build include version numbers and info from the build: "SomePackage_RelWIthDebInfo_1.0.0-rc4.deb"
So I would like to upload it with:

assets: *.deb