xrchz/rocketarb

Arbitrage rETH mint/burn with minipool deposit/withdrawal

rocketarb's Issues

Change flashloan provider

Euler was hacked and completely drained so their flashloan provider is pretty useless now;

https://nitter.fly.dev/peckshield/status/1635229594596036608#m

https://etherscan.io/token/0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2?a=0x27182842e098f60e3d576794a5bffb0777e025d3

Does rocketarb work on testnet?

Just want to try it out first if possible. Thanks!

Improve the logs

Howdy,

I have two suggestions:

1. improve the logs to make it more obvious why the transaction reverted in a --dry-run
2. (not sure if possible) say what the current bundle's set base and priority fee are

Sample output for running the commands

Is it okay to add some sample output when commands are run? Even one sample output would help someone new to understand how the script would work and what the output would look like.

RocketArb for LEB8 mini pools

Any plans to update this tool for Atlas/8 ETH minipools?

nonce too low when running `./scripts/rocketarb-docker.sh --dry-run`

./scripts/rocketarb-docker.sh --dry-run

yields

{
  "error": {
    "message": "err: nonce too low: address REDACTED, tx: 5 state: 8; txhash REDACTED",
    "code": -32000
  }
}

any idea why?

out-of-bounds Error When using custom RPC

I tried using rocketarb when my primary client is not synced and used my fallback as custom RPC. Rocketarb gives me out of bounds exception when creatign the arb transaction.

Here are detailed logs:

$ ./scripts/rocketarb-docker.sh -n --rpc http://proteus:8545
Welcome to RocketArb: Deposit!
Have you tried almost depositing your minipool using the smartnode? y
Got smartnode version 1.10.1

Creating deposit transaction by executing smartnode: docker exec rocketpool_node /go/bin/rocketpool api node deposit 8000000000000000000 0.14 6131696543806149 true false
2023/08/15 16:46:02 Primary execution client is still syncing (100.00%), using fallback execution client...
2023/08/15 16:46:02 Primary execution client is still syncing (100.00%), using fallback execution client...
Got deposit transaction data from smartnode
Creating arb transaction
/app/node_modules/@ethersproject/logger/lib/index.js:238
        var error = new Error(message);
                    ^

Error: value out-of-bounds (argument="ethAmount", value={"type":"BigNumber","hex":"-0xa6fdd7f434f4b2fd"}, code=INVALID_ARGUMENT, version=abi/5.7.0)
    at Logger.makeError (/app/node_modules/@ethersproject/logger/lib/index.js:238:21)
    at Logger.throwError (/app/node_modules/@ethersproject/logger/lib/index.js:247:20)
    at Logger.throwArgumentError (/app/node_modules/@ethersproject/logger/lib/index.js:250:21)
    at Coder._throwError (/app/node_modules/@ethersproject/abi/lib/coders/abstract-coder.js:41:16)
    at NumberCoder.encode (/app/node_modules/@ethersproject/abi/lib/coders/number.js:46:18)
    at /app/node_modules/@ethersproject/abi/lib/coders/array.js:74:19
    at Array.forEach (<anonymous>)
    at pack (/app/node_modules/@ethersproject/abi/lib/coders/array.js:60:12)
    at TupleCoder.encode (/app/node_modules/@ethersproject/abi/lib/coders/tuple.js:71:33)
    at AbiCoder.encode (/app/node_modules/@ethersproject/abi/lib/abi-coder.js:91:15) {
  reason: 'value out-of-bounds',
  code: 'INVALID_ARGUMENT',
  argument: 'ethAmount',
  value: BigNumber { _hex: '-0xa6fdd7f434f4b2fd', _isBigNumber: true }
}

Node.js v19.5.0

Improve the logs

Howdy,

I have two suggestions:

1. improve the logs to make it more obvious why the transaction reverted in a --dry-run
2. (not sure if possible) say what the current bundle's set base and priority fee are

Doesn't work with smartnode 1.11.12

Here's the output from a dry run:

$ ./scripts/rocketarb-docker.sh --dry-run
Welcome to RocketArb: Deposit!
Have you tried almost depositing your minipool using the smartnode? y
Got smartnode version 1.11.2

Creating deposit transaction by executing smartnode: docker exec rocketpool_node /go/bin/rocketpool api node deposit 8000000000000000000 0.14 533611257236573 true false
Got deposit transaction data from smartnode
Creating arb transaction
/app/node_modules/@ethersproject/logger/lib/index.js:238
        var error = new Error(message);
                    ^

Error: value out-of-bounds (argument="ethAmount", value={"type":"BigNumber","hex":"-0x55469ba6564b81869a"}, code=INVALID_ARGUMENT, version=abi/5.7.0)
    at Logger.makeError (/app/node_modules/@ethersproject/logger/lib/index.js:238:21)
    at Logger.throwError (/app/node_modules/@ethersproject/logger/lib/index.js:247:20)
    at Logger.throwArgumentError (/app/node_modules/@ethersproject/logger/lib/index.js:250:21)
    at Coder._throwError (/app/node_modules/@ethersproject/abi/lib/coders/abstract-coder.js:41:16)
    at NumberCoder.encode (/app/node_modules/@ethersproject/abi/lib/coders/number.js:46:18)
    at /app/node_modules/@ethersproject/abi/lib/coders/array.js:74:19
    at Array.forEach (<anonymous>)
    at pack (/app/node_modules/@ethersproject/abi/lib/coders/array.js:60:12)
    at TupleCoder.encode (/app/node_modules/@ethersproject/abi/lib/coders/tuple.js:71:33)
    at AbiCoder.encode (/app/node_modules/@ethersproject/abi/lib/abi-coder.js:91:15) {
  reason: 'value out-of-bounds',
  code: 'INVALID_ARGUMENT',
  argument: 'ethAmount',
  value: BigNumber { _hex: '-0x55469ba6564b81869a', _isBigNumber: true }
}

Node.js v19.9.0

Better error handling for 1inch

Or even better, figuring out why it happens and changing that so it doesn't :)

Got 500 from 1inch
node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "#<IncomingMessage>".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v19.3.0

Suggest having an error handler here that prints out the code and also the message - 1inch usually delivers a reason it returned a 500.