xtravar/cppnet

Quick and dirty port of jcpp to .NET, with features to support Clang preprocessing

cppnet's Issues

A newline should be added at end of included files, if not present

At the moment, CppNet does not add a newline at the end of an included file, if there is not already one present. This creates a problem, because the #line directive when you come back to the original file ends up on the same line as the last line of the include:

// this is the original file
#line 1 "Include.hlsl"
// this is the include file
int a; #line 43 "OriginalFile.hlsl"
// carry on with the original file

According to this SO answer, all preprocessors these days detect this case, and add a newline for you.

I've had a look, but I'm not entirely sure where this should be added in CppNet. Any ideas?

(By the way, @xoofx, have you hit this issue in Paradox?)

Stripping #line directives

It seems like if the input file contains existing #line directives they are stripped out. It would be better for CppNet to just ignore them.

Crash On Unknown Directive

If you pass a file with any unknown directive like:

#notgood

You get a crash processing a token:

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at CppNet.Preprocessor._token()
   at CppNet.Preprocessor.token()

This probably shouldn't crash... it should probably return some unknown directive type. At worst it should output a reasonable error message and fail to parse.