yaegassy/coc-ruff

ruff-lsp (ruff) extension for coc.nvim

coc-ruff's Issues

Passing args cause ruff to stop linting

I have currently enabled autofix but want some rules to be not autofixable. Ruff provides a setting --unfixable exactly for this. I tried setting ruff.args=["--unfixable F401"] in coc-settings.json. As soon as I add this setting, coc-ruff stops working with no linting and fixing at all.

Adding whitespace before colon

The wrapping of astral-sh/ruff seems to be adding whitespace before colons and triggering the linter E203 after formatting fix. It seems like this was also an issue with astral-sh/ruff, issued here: astral-sh/ruff#8642 and fixed in 2023. Can this be fixed easily by upgrading to a new version of astral-sh?

Auto fix on file save

We can apply auto fix by running ruff.executeAutofix command. It would have been really nice if we get a configuration option for auto fix on file save like in coc-eslint.

Autofix doesn't save file automatically after fix

I have "ruff.autoFixOnSave": true in my coc settings. Whenever I save my file, ruff applies fixes but doesn't save the file. This behaviour is different from extensions like coc-eslint which save the file with the fix applied.

"CocCommand ruff.builtin.installServer" failed on windows10

Dear coc-ruff developer, coc-ruff are great. Thanks for your contribution. While I tried to install ruff-lsp on windows10 using CocCommand, it failed. Here comes the error messages:

[coc.nvim] Installation of ruff-lsp failed. | Error: Command failed: D:\Program Files\Python38\python.EXE -m venv D:\Users\xxx\AppData\Local\coc\extensions\@yaegassy\coc-ruff-data\ruff-lsp\venv && D:\Users\xxx\AppData\Local\coc\extensions\@yaegassy\coc-ruff-data\ruff-lsp\venv\Scripts\python -m pip install -U pip ruff-lsp==0.0.27
'D:\Program' �����ڲ����ⲿ���Ҳ���ǿ����еij���

After I do the next three steps, everything goes fine. Hope It will benefit other junior windows users like me. And would you consider optimizing the install command?

1. create a virtulenv,
2. install ruff-lsp in exact virtualenv ,
3. assign the actual ruff path via CocConfig:
   "ruff.path": ["D:/User/xxx/AppData/Local/coc/extensions/@yaegassy/coc-ruff-data/ruff-lsp/venv/Scripts/ruff"],