Release assets fallback to first/default .zip even if releaseassets regex is applied.

[melcarthus]

Release assets fallback to first/default .zip even if releaseassets regex is applied.

[YahnisElsts]

Ah, it sounds like there was also a PUC version issue. There have been some changes to how release assets work with the update checker, but I forgot that I haven't published those changes as a new release yet. So you might get different behaviour depending on if you used the 5.0 release or the master branch of this repository.

I'll make a note to release a new PUC version.

[YahnisElsts]

One possible issue is regex syntax. PUC uses the provided regex as-is, without adding any delimiters or flags. So if your regex is literally 'landingpages.zip', that's not going to work because without delimiters that's not a valid PCRE regex pattern. Try changing it to something like '/landingpages.zip/'.

[melcarthus]

Just changed it to a better pattern. Stil points to the main release zip.

[YahnisElsts]

That part of the code doesn't have enough logging to effectively debug it remotely. Would you perhaps be willing to step through it yourself or add some logging statements? This is the method that checks if an asset link/name matches the regex:

https://github.com/YahnisElsts/plugin-update-checker/blob/579d537926c41e6d4b82cf2c73f5ba85d96a8e1e/Puc/v5p0/Vcs/ReleaseAssetSupport.php#LL61C28-L61C28

[melcarthus]

Sure no problem. However I failed to mention the repo is a private repo. And maybe it cant find this asset because the link contains no token like the default asset link does have. Or am i overthinking it?

Update

The problem it was not pointing to the correct asset was first of all the delimiters.
It would still not point to the right assetslink because of two missing files. Why they where missing when I downloaded the plugin i'm not sure about. But everything is working now as intended!

I was missing ReleaseAssetSupport.php and ReleaseFilteringFeature.php