Giter Site home page Giter Site logo

Comments (11)

YahnisElsts avatar YahnisElsts commented on June 5, 2024

It looks like Query Monitor attempts to emulate the Debug Bar plugin when that plugin isn't active. PUC has limited Debug Bar integration, so under certain conditions, it adds a callback to the debug_bar_panels filter that QM calls here:
Debug_Bar::init_panels() wp-content/plugins/query-monitor/classes/debug_bar.php:53

During that, PUC tries to load some classes related to the Debug Bar. Which apparently doesn't work because the Debug_Bar_Panel class doesn't exist. I think this probably happens because QM autoloads its version of Debug_Bar_Panel, and PUC specifically disables autoloading for the relevant class_exists() check.

However, I can't figure out what scenario could actually lead to that chain of events. You need a situation where the Debug_Bar class already exists but Debug_Bar_Panel does not. Maybe something else makes QM load Debug_Bar earlier than usual? Do any of the other plugins on those sites use Debug Bar? Their tabs might also show up in QM.

from plugin-update-checker.

daigo75 avatar daigo75 commented on June 5, 2024

Unfortunately, I don't have any other information about the issue. The affected sites, both of which threw the error between yesterday and today, belong to clients, but I don't have access to them, due to data protection policies. Neither client is tech savvy, nor do they have a person who can provide technical details, therefore we're still at a preliminary investigation level, at least until someone can provide more details about the conditions that cause the issue.

from plugin-update-checker.

YahnisElsts avatar YahnisElsts commented on June 5, 2024

Well, I have an idea about how the error can be avoided, but I don't have a way to verify if it will actually work since I can't reproduce the error. And if you don't have access to the sites, you might not be able to verify the fix either.

If you'd like to try it anyway, switch from version 5.1 of PUC to what's currently in the master branch.

from plugin-update-checker.

daigo75 avatar daigo75 commented on June 5, 2024

I would be happy to try the master branch, but I wasn't able to reproduce the error myself, either. Due to that, there's no way of knowing if the fix will work.

I will ask the clients if they could grant access to a staging site for testing. If they agree, I will report back here. If not, I will have to wait until I get the chance to run the test.

from plugin-update-checker.

JiveDig avatar JiveDig commented on June 5, 2024

Noting I hit the same error this morning. Deactivated Query Monitor via WP-CLI so I could access the Dashboard.

CleanShot 2023-10-20 at 12 10 12@2x

from plugin-update-checker.

daigo75 avatar daigo75 commented on June 5, 2024

@YahnisElsts Just a quick update. Another user reported the same error. Unfortunately, I couldn't get access to a staging site (they are all very strict with the access), so I couldn't test the proposed fix. If there's going to be a new version coming soon, please let me know and I will update my plugins too.

from plugin-update-checker.

YahnisElsts avatar YahnisElsts commented on June 5, 2024

I could create a new release pretty easily, but I'm a bit reluctant to do that when I don't know if the fix actually works.

from plugin-update-checker.

JiveDig avatar JiveDig commented on June 5, 2024

@YahnisElsts What's the best way to test (if I hit it again)? Do I run the develop branch, or just change that line manually in my plugin on the site with issues?

from plugin-update-checker.

YahnisElsts avatar YahnisElsts commented on June 5, 2024

I think either would work. Changing the line yourself might be slightly safer because the repository could (at some point) include other, unrelated changes.

from plugin-update-checker.

daigo75 avatar daigo75 commented on June 5, 2024

@YahnisElsts I prepared a build of my plugin that includes the proposed changes, then asked some of my customers to try it on their sites. After installing the update, the error went away. It reappeared shortly after, due to the presence of another plugin (Admin Menu Editor Pro) which includes the "old", unpatched version of the Plugin Update Checker library, but that is a further confirmation that the patched version works.

from plugin-update-checker.

YahnisElsts avatar YahnisElsts commented on June 5, 2024

All right, I've made a new release, version 5.3. I will also update Admin Menu Editor Pro sometime this week.

from plugin-update-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.