Not seeing "Install Update Now" button in plugin details popup

[MichelleBlanchette]

Not seeing "Install Update Now" button in plugin details popup

[Thiararapeter]

Hello, There is an issue with installed plugin. when i click open view detail and te plugin is installed, be button should be "latest verson installed" but am getting "install now button" mostly works but after plugin updates, yes the plugin is installed but on view details plugin have "install now" attached will demonstrate what am trying to say. [cid:7130d225-aa01-4d51-8989-a6777af75774][cid:cb97783a-dad9-4374-8fa2-12f6e0eb1d2e] Regards, Thiarara

…

________________________________ From: Yahnis Elsts ***@***.***> Sent: Monday, January 8, 2024 1:34 AM To: YahnisElsts/plugin-update-checker ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [YahnisElsts/plugin-update-checker] Not seeing "Install Update Now" button in plugin details popup (Issue #551) I tested it just now, and it seems to show up fine even in the latest alpha version of WordPress. Here's a couple of screenshots from an example plugin that's using PUC release 5.3: firefox_2024-01-08_11-17-20.png (view on web)<https://github.com/YahnisElsts/plugin-update-checker/assets/2527434/77dfe695-42d6-4f30-8c19-b49001dad2b5> firefox_2024-01-08_11-28-46.png (view on web)<https://github.com/YahnisElsts/plugin-update-checker/assets/2527434/296163c4-72c3-4954-81fe-f9d80212c5a9> (The plugin metadata is old, but the PUC version is new.) Is there anything unusual going on with how PUC is configured in your case? Maybe a custom slug that doesn't match the slug shown in the Debug Bar? Or modifying the download_url with custom filters? — Reply to this email directly, view it on GitHub<#551 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJWVCN44GLE2SIKZWP7XIGTYNO4SDAVCNFSM6AAAAABBOO7JG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGY2TANZWGI>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[YahnisElsts]

Verify that your update server returns a download link (i.e. download_url isn't missing or empty). A quick skim of WordPress core code suggests that it won't show this button if there is no download link.

[MichelleBlanchette]

Yes, I saw the same thing in WordPress Core's source code. However, Debug Bar is showing that I am indeed retrieving a proper download_url field. (see attached)

Have you confirmed this "Install Update Now" button is supported to work via PUC v5, then? Really, I just wanted confirmation from your end that the button does appear in your own testing of PUC v5.

[YahnisElsts]

I tested it just now, and it seems to show up fine even in the latest alpha version of WordPress. Here's a couple of screenshots from an example plugin that's using PUC release 5.3:

(The plugin metadata is old, but the PUC version is new.)

Is there anything unusual going on with how PUC is configured in your case? Maybe a custom slug that doesn't match the slug shown in the Debug Bar? Or modifying the download_url with custom filters?

[MichelleBlanchette]

Those screenshots are incredibly helpful. Thank you! I don't know of anything unique or special about my implementation, though.

I'll add some deep logging in WordPress Core and see if I can track down what's causing this. I'm not so much concerned about the button not showing as much as it's an indication that there's unexpected behavior happening.

I'll let you know what I find!