yalantis/apiclient

apiclient's Issues

Authorization plugin

Simple auth plugin is required. In case client won't use exchange tokens flow, the implementation of RestorationTokenPlugin is required only to provide auth token and looks like the following:

extension UserSessionController: AccessCredentialsProvider {
    
    public var accessToken: String? {
        get { return userSession.userMetadata.accessToken }
        set { /* no-op; we're not using session restoration flow */ }
    }
    
    public var exchangeToken: String? {
        get { return nil }
        set { }
    }
    
    public func commitCredentialsUpdate(_ update: (AccessCredentialsProvider) -> Void) {
        // no-op; we're not using session restoration flow
    }
    
    public func invalidate() {
        // no-op; we're not using session restoration flow
    }
}

empty response parsing

in case there's an empty response APIClient couldn't parse it and sends errors:
Error Domain=NSCocoaErrorDomain Code=3840 "No value." UserInfo={NSDebugDescription=No value.}

need to handle the case in JSONDeserializer:

func deserialize(_ response: HTTPURLResponse, data: Data) throws -> AnyObject {
        do {
           ...
        } catch {
            if (error as NSError).code == 3840 { // empty response
                return .success(NSArray())
            }
               ...
        }
    }

Unable to make multipart request

Because of RestorationTokenPlugins prepare` method multipart request check fails:
https://monosnap.com/file/u7FVqgPpBj2b4Sm58obGhJcma31t1l

error parsing

currently, NetworkError being parsed only in case there's no body in response:

request.responseJSON(completionHandler: { response in
	guard let httpResponse = response.response, let data = response.data else {
	    AlamofireRequestExecutor.defineError(response.error, completion: completion)
	    return
	}

	completion(.success((httpResponse, data)))
})

in that case flow goes to APIClient and it invalidates response due to header (validateResult method)

Could You Provide a demo or tutorial how you build this or how to use it

Marshal support

According to comparisons, Marshal looks like the best solution. Consider adding support for it

dependency "APIClient" has no shared framework schemes for any of the platforms: iOS

It was working fine till Xcode 10.1 and Swift 4.2. Once I updated Xcode to 10.2.1 which support Swift 5.0, I started getting this error. I using Carthage manage dependencies.

Your Environment

• Version of the component: 2.8
• Swift version: 5.0
• iOS version: 12.2.0
• Device: n/a
• Xcode version: 10.2.1
• If you use Cocoapods: n/a
• If you use Carthage: 0.33.0

Project that demonstrates the bug

Please add a link to a project we can download that reproduces the bug.