yannick-cw/scalassss

Scala implementation of shamir's secret-sharing scheme.

scalassss's Issues

Some suggestions by `/u/m50d` on reddit

Looks good, pretty clear.

Is the prime a BigInt or a String? You say both in parts of the readme.

Why MD5? Is it specified? Seems an odd choice for a new project.

You might like to use a StringContext pimp for BigInt literals.

Why is BigPrimes#primes a List? Wouldn't some kind of map be better?

LaGrangeInterpolation#L19 the -> is misleading.

gcdD should probably return a case class rather than a list? Or I may be misunderstanding.

Consider parameterizing SSSSOps by F[_]: Monad (and the implementation uses Either[ShareError, ?] (kind-projector syntax)) rather than parameterizing by Error - that's more in line with what people would expect.

There's a lot of cases when you're foldLefting with something that's literally a group (so certainly a monoid). Scala has an awkward relationship with multiple groups using the same base set, but you might consider representing multiplicative integers mod p (or the kind of linear-congruence stuff you're doing) with a wrapper type that has a monoid instance, and then you can replace a lot of the foldLefts with just sum operations. Have a look at spire which may have the algebraic constructs you're using already.