yapiolibs/hamlib-rotctl-easycomm-parser

Easycomm parser library for Hamlib rotator control (written in C for C and C++ projects)

hamlib-rotctl-easycomm-parser's Issues

[FR] implement get `UM`/`DM` mode

Description
According to the command reference UM/DM without arguments shall respond with the current setting but the implementation is missing.

Solution

• implement parser for UM/DM without arguments

[FR] update to PlatformIO 6.0

Description

• do update the code to be compliant
  • with PlatformIO 6.0 + Unity (needs: platformio.ini update and implementation of further Unity transport, etc)
• do code cleanup so that all commands and related methods are called
  • ...setCommandXXX... and ...getCommandXXX... when commands can be used as setter and getter
  • ...doCommandXXX... when commands are only used to trigger actions

[FR] implement get `UP`/`DN` frequency

Description
According to the command reference UP/DN without arguments shall respond with the current setting but the implementation is missing.

Solution

• implement parser for UP/DN without arguments

[BUG] problem using sscanf with platform ststm32

Description
Set time command fails to parse on ststm32 platform.

How to reproduce

• pio test -e ststm32 -f easycomm2_ao_lo_op_ip_an_st_ve

test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:254:test_parse_acquisition_of_signal	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:255:test_parse_loss_of_signal	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:256:test_parse_set_output_01	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:257:test_parse_set_output_02	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:258:test_parse_read_input_01	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:259:test_parse_read_input_02	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:260:test_parse_read_analogue_input_01	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:261:test_parse_read_analogue_input_02	[PASSED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:53:test_parse_set_time_01:FAIL: failed to parse	[FAILED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:53:test_parse_set_time_02:FAIL: failed to parse	[FAILED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:53:test_parse_set_time_03:FAIL: failed to parse	[FAILED]
test/easycomm2_ao_lo_op_ip_an_st_ve/test.cpp:265:test_parse_request_version	[PASSED]

Expected behaviour
All tests green.

run ci tests on recent ubuntu 21.10 (hamlib 4.x) insted of old 20.04 (hamlib 3.x)

As of 04.2022 unfortunately GH actions did not release a newer Ubutu virtual enrionment thus ubuntu-latest still refers to 2y old 20.04.

Problem: 20.04 (ubuntu-latest) comes with Hamlib 3.x and the behaviour diverges to current Hamlib 4.x.
Solution:

• Either wait for new virtual environment and keep integration tests less restrictive or
• set the yaml-actions up to use a custom repository and install new Hamlib.

[FR] implement get `UR`/`DR` radio

Description
According to the command reference UR/DR without arguments shall respond with the current setting but the implementation is missing.

Solution

• implement parser for UR/DR without arguments

[BUG] update integration tests once https://github.com/Hamlib/Hamlib/issues/1006 is fixed

Description
In rotctl the Easycomm protocol (--model=204) defines a wrong callback easycomm_rot_move_velocity for the \move command.
See Hamlib/Hamlib#1006.

How to reproduce
Run the following integration tests:

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 325 in 4edf9bd

def _test_easycomm2_rotctl_v4_move_up():

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 348 in 4edf9bd

def _test_easycomm2_rotctl_v4_move_down():

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 371 in 4edf9bd

def _test_easycomm2_rotctl_v4_move_left():

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 394 in 4edf9bd

def _test_easycomm2_rotctl_v4_move_right():

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 423 in 4edf9bd

def _test_easycomm3_rotctl_v4_move_up():

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 446 in 4edf9bd

def _test_easycomm3_rotctl_v4_move_down():

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 469 in 4edf9bd

def _test_easycomm3_rotctl_v4_move_left():

hamlib-rotctl-easycomm-parser/test/integration/tests.py

Line 492 in 4edf9bd

def _test_easycomm3_rotctl_v4_move_right():

Expected behavior
Once the bug Hamlib/Hamlib#1006 is fixed the listed tests have to be updated accordingly.