Comments (8)
Huh. That is odd, and should not happen unless of a huge lag spike.
Can you provide an example of a song where this happens? (just the name and source is fine).
Can you also tell me if you were lag spiking or not?
Thanks for the issue report, and apologies for the inconvinience.
from yarg.
I was playing Painkiller by Judas Priest and Green Grass and High Tides by The Outlaws(Wavegroup), both of them come from that spreadsheet of songs from Clone Hero: https://docs.google.com/spreadsheets/u/0/d/13B823ukxdVMocowo1s5XnT3tzciOfruhUVePENKc01o/htmlview#gid=0
from yarg.
I also have to play on low quality mode, otherwise the game is very laggy.
from yarg.
Thanks for the info, I'll investigate it ASAP.
from yarg.
Howdy. Through some investigation, my assumption is that when the game lags, the audio doesn't, which causes desync. To prevent this, I added an option in the settings menu that bases the current time on the audio instead of Unity's delta-time (which is what was being used).
Now, there are some issues attached with basing the time off of the audio instead of the game time, but I think that it may solve the problem you are having.
Below, I attached a zip-file containing the current dev-build. If you don't mind, can you test to see if this fixes the problem for you? Be sure to go into the settings and turn “Use Audio Time” on. Please be advised that the settings do not save between sessions yet.
If this fixes the issue, please close this issue. If not, please let me know. Thanks!
Edit: GitHub could not host the file due to size. Here is a Google drive link: https://drive.google.com/file/d/1JSFvNPGa1-IebQiP7lS6HEPgVb2oazQr/view?usp=share_link (dead).
from yarg.
This seems to have fixed the issue, although now songs don't end.
from yarg.
Okay, thanks for testing! Yes, I forgot to account for the song ending with the new setting, so that will be fixed with the next release.
from yarg.
I've fixed the song ending issue. If you'd like to continue playing, here is a dev-build hot-fix. Thanks again!
https://drive.google.com/file/d/1deLy0nuYRkjHyFlwFo1MOrY7b7ZeUhiT/view (dead)
from yarg.
Related Issues (20)
- Duplicate songs HOT 1
- Feature request: Profiles UX Change HOT 1
- very minor bug about hit window again
- Problems with YARG stable HOT 1
- Dynamic hit window is incorrectly locked to the smallest possible size.
- Feature Request: Audio slider for stems that do not have an active player.
- Blue toms not converted correctly in some Guitar Hero drum charts
- Request: Clearer feedback on open note strums
- Pro Drum Navigation Not Working Within Search Interface HOT 4
- Longer section titles in music menu HOT 3
- Feature Request: Library Navigation Suggestion (Jumping through headers) HOT 4
- Font issues with lyric text (missing glyphs) HOT 1
- Crash at startup in Linux HOT 3
- Thicken open notes for the circular style HOT 1
- Request: make albums not be case sensitive HOT 2
- notes.mid files with open notes on Easy on GHL instruments do not load HOT 2
- Background Video Only Working For Certain Songs HOT 1
- YARG scan all computer at launch. MAC HOT 2
- Disconnecting a midi device during a song causes the game to crash. HOT 4
- Controller disconnects as soon as it's plugged in HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yarg.