Giter Site home page Giter Site logo

yarc-official / yarg Goto Github PK

View Code? Open in Web Editor NEW
669.0 25.0 142.0 152.82 MB

YARG (a.k.a. Yet Another Rhythm Game) is a free, open-source, plastic guitar game that is still in development. It supports guitar (five fret), drums (plastic or e-kit), vocals, pro-guitar, and more!

Home Page: https://yarg.in/

License: GNU Lesser General Public License v3.0

C# 92.44% ShaderLab 6.60% HLSL 0.76% JavaScript 0.20%
rockband clone-hero guitar-hero

yarg's People

Contributors

berthrage avatar eckerj avatar eliteasian123 avatar escapenumber001 avatar grishhung avatar jaydiddythagoat avatar jgoyvaerts avatar jnackmclain avatar jtanan44 avatar kaduwaengertner avatar kernaltrap8 avatar llysix avatar localh avatar muskit avatar narriksynthfox avatar neomattgz avatar nevespt avatar nyxtheshield avatar pantotone avatar raphaelgoulart avatar rileythefox avatar rjkiv avatar roystermeat avatar samuelpalma avatar santorfo avatar sonicfind avatar thefatbastid avatar thenathannator avatar thoudankeykang avatar vinaykapadia avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

yarg's Issues

Stuck in Player 1 screen

image

I get to load some clone hero charts, but I get stuck on that screen after hitting play with my mouse. I am able to go back by pressing the left arrow on the screen.

Does this game support .chart format?

And while I'm at it, will this game have full mouse support? That would be huge for newcomers.

Modifiers

These are to let the players change the gameplay experience. Ex: All tap, all HOPOs, all strums, brutal mode.

Full Mouse Support

Add full mouse support when in the menus, especially when in the difficulty select screen.

JSON for Ouvertbot

I tried with a custom song for rb3 and that work good, i saw for cache is a json file, so i use with Ouvertbot (a bot for request songs for clone hero) and that works except, we don't have the artist, album, genre and the charter

Is it in your plans that the cache file have info for the Ouvertbot ? that would be really great!

image

(Help) Pro-guitar Controller Support

Current, the only supported pro-guitar is the WII fender mustang. Obviously, not everyone has a WII one, so I'd like to add support for the Xbox and PS3 fender mustangs. Problem is, since I don't have access to those devices, I don't know the PID and VID for those. This means that YARG can't detect those devices.

If anyone can provide me with the PID and VID's for the Xbox and/or PS3 fender mustang, that would be greatly appreciated. Thanks.

Support for Wii, PS3, and Xbox Fender Mustangs should be working, however I need people to test them. Below are a list of controllers that are confirmed to work:

  • Wii Fender Mustang
  • PS3 Fender Mustang
  • Xbox Fender Mustang

If anyone has any of the missing ones and would like to test it out, please let me know.

Is the 3 drum and 2 cymbal peripheral drums going to be supported?

Hello again! I was just wondering if the 3 drum and 2 cymbal peripheral is going to be supported? I know this program is mainly focused on Rockband peripherals but as I only have that drum set at home it would be fun if that were to be an option although I understand if not!

Hierarchical Songs View

Hey! So I see this project is still pretty early in it's development so I thought now would be the perfect time to suggest something like this :)

With ever-growing song libraries it can get quite chaotic in the songs view, at least in currently available Guitar Hero / Rock Band clones.

I've got a pretty well organized system for my Clone Hero songs and albums.
2 examples would be:
Custom Songs\1. Original\Guitar Hero 3\Tier 1\... songs here ...
Custom Songs\2. Custom\CSC\<month.year>\... songs here...

I do this so I have the original game songs sorted before the custom ones.

With this I have to scroll pretty much endlessly until I find the ones I want to play.

So I'd like to suggest the idea of a hierarchical view.

This way we would see all songs in the top-most folder together with the folders it has.
Then, we can go into one of those folders and see all charts in there, with extra folders it has at the top.
Repeat until we're in a folder that doesn't have any more songs.

Would this be something that could be included in the future?
Perhaps not by default, but as an option would be really cool!

(Bug) Songs list is blank if I change to another songs folder

sorry for being a pain in the ass with all the issues 😅, but i found another problem

i used to have a songs folder with only 3 songs for testing stuff, but i decided to change the songs location to a folder with more songs and.... even when i use the "refresh cache" option, the songs list is blank, it just says "Song Name - Artist - No Score - 1:23 - Custom" and "..." where the album cover should be, i waited for an hour and restarted the game multiple times, but it just don't show any song in the list

(yes, i got the 0.3.4 build)

(Roadmap) Five-Fret Guitar

Five-Fret Guitar Roadmap

  • Notes
    • Normal notes
    • Sustain notes
    • HOPO notes
    • Tap notes
    • Open notes
    • Open tap notes
    • Scores
  • Starpower
    • Starpower sections
    • Starpower bar
    • Starpower effects
  • Extras
    • Guitar solos
    • Big rock endings
    • Whammy
  • Difficulty downsampling
    • Easy
    • Medium
    • Hard
  • Controllers
    • Generic gamepads
    • Let me know if any others.

[BUG] Playing with vocals doesn't allow getting past difficulty select

To reproduce:

  1. Have a microphone player set up
  2. Go to Quickplay, choose a song
  3. Choose the mode
  • Solo/harmony lets us continue to the next step
  • Sit Out raises an exception in the same fashion as the next step
  1. Choose the difficulty for vocals. You'll be unable to proceed, as an exception is raised:
ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
System.Collections.Generic.List`1[T].get_Item (System.Int32 index) (at <88e4733ac7bc4ae1b496735e6b83bbd3>:0)
YARG.UI.DifficultySelect.IncreasePlayerIndex () (at Assets/Script/UI/DifficultySelect.cs:189)
YARG.UI.DifficultySelect.Next () (at Assets/Script/UI/DifficultySelect.cs:167)
YARG.UI.DifficultySelect.ClickOption (YARG.UI.GenericOption option) (at Assets/Script/UI/DifficultySelect.cs:140)
YARG.UI.GenericOption.MouseClick () (at Assets/Script/UI/GenericOption.cs:27)
UnityEngine.Events.InvokableCall.Invoke () (at <ba783288ca164d3099898a8819fcec1c>:0)
UnityEngine.Events.UnityEvent`1[T0].Invoke (T0 arg0) (at <ba783288ca164d3099898a8819fcec1c>:0)
UnityEngine.EventSystems.EventTrigger.Execute (UnityEngine.EventSystems.EventTriggerType id, UnityEngine.EventSystems.BaseEventData eventData) (at Library/PackageCache/[email protected]/Runtime/EventSystem/EventTrigger.cs:220)
UnityEngine.EventSystems.EventTrigger.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at Library/PackageCache/[email protected]/Runtime/EventSystem/EventTrigger.cs:277)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at Library/PackageCache/[email protected]/Runtime/EventSystem/ExecuteEvents.cs:57)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at Library/PackageCache/[email protected]/Runtime/EventSystem/ExecuteEvents.cs:272)
UnityEngine.EventSystems.EventSystem:Update() (at Library/PackageCache/[email protected]/Runtime/EventSystem/EventSystem.cs:514)

Occurs with single and multiple microphones, bots or controlled players. Debugging in Unity Editor, I see that DifficultySelect is stuck at -1, and an exception occurs when trying to access PlayerManager.players[playerIndex].

Tap Mic star power activation?

Heya, I was wondering if adding the classic Guitar hero mic starpower activation style is possible? It would be really cool to just be able to hit the top of the mic and activate starpower or something. It might be hard to implement but I figured I'd at least ask. Basically adding a keybind option to activate starpower for the mics.

(Roadmap) Drums

Drums Roadmap

  • Notes
    • Normal notes
    • Kick notes
    • Double-kick notes
    • Pro/cymbal notes
    • Soft/hard notes
    • Scores
  • Starpower
    • Starpower sections
    • Starpower bar
    • Starpower effects
  • Extras
    • Drum fills
    • Big rock endings
  • Difficulty downsampling
    • Easy
    • Medium
    • Hard
  • Controllers
    • MIDI drums
    • Normal RB drums (4-lane)
    • Normal GH drums (5-lane) (#28)

Multiple song folder support?

Heya! This isn't super important but I figured I'd mention it anyways. Adding support for multiple song folders helps with organizing a bit and would be very appreciated if considered!

Better Menus

Create a new main menu, settings menu, etc. and steer away from using UIDocuments.

Implement lefty flipped drums correctly.

Lefty drums does two things:

  • Mirrors the chart while keeping the color of the lanes the same. (This means we now have a red cymbal)
  • Makes the green cymbal input trigger a red cymbal.

It its not a simple mirroring of the screen like guitar is.

For 5 lane something similar can be done here.


Rock band 3 screenshots for reference

Righty drums:
Screenshot_2023-04-07_18-11-48

Lefty Drums:
Screenshot_2023-04-07_18-12-05

highway dim

The addition of a slider in the settings menu to adjust how dim the highway should be, would make it easier for users to read notes.

(Bug) Song chart starts with over 15 seconds of delay

as the title says, the songs start with a veeery long delay, the music starts first, and then the chart comes with like 15 or more seconds of delay, even using the "Use Audio Time" option in settings menu or calibrating the game isn't fixing this issue

nonstop scrolling up on song selection screen - (Wii Harmonix guitar)

Hi. My friends and I have been playing a lot of YARG, huge fan! Thanks for all your work on it.

When running the program on my friend's steamdeck using his xbox RB controllers, we were able to play without many issues -- super fun. But when I try running YARG on my PC using my Wii RB controllers, the guitar pairs, but almost always will endlessly scroll upward on the Song Selection screen (and I can't get my drums to pair at all).

I know you must have a lot on your plate with this, but just wanted to let you know. Can't wait to keep seeing YARG develop. Thanks!

Switch to a Different Mic Audio Engine

Unity's “real-time” mic system has a very high latency, so much so that Karaoke mode is hard to use due to the high-latency.

Switch to a different mic solution to solve this issue.

(Bug) Wired XInput (Xbox) devices aren't detected

while i can see the "Mouse" and "Keyboard" options, for some reason my Wired Xbox 360 Guitar (Rock Band 1 model) don't appear in the list of devices i can play with while creating a new player profile, even if i use the "refresh" option

Ardwiino support

This project looks dope!

If i were to submit a PR for adding in reactive LED support for my new firmware, would that sorta thing be merged in?
The plan is to use HID output reports for enabling and disabling LEDs depending on game state for HID, and rumble commands for xinput.

It would be cool to have something with proper support for this baked in, as then I have a nice way to test all these new features before I investigate modding other games.

Happy to send test firmwares your way or something if you do happen to have a arduino / pico modded guitar and want to test things yourself once it gets to that point, assuming the new firmware isn't released by the time i get around to this.

(Bug) Game freezes causing desyncing

i just got the most recent version to try it out, and i noticed the game have some moments where it freeze for a second, then continues, but when it continues the song gets out of sync, making it to not pair with the music

i tried it on vocals and guitar so far, but i guess the issue would be the same on drums

(as a side note, my PC is veery low end, so that might be a problem on my end lol)

Pause feature

I figure this is already planned but was wondering if it's in the works and in that case how the progress is on it?

Settings Saving

Heya, noticed that players aren't saved on quit, is this intended? Like is it just not implemented yet?

Disco Flipping

Some songs switch the red and yellow pads sometime (for some reason). Add support for that.

Beatles Hofner Bass + Chinese 360 Wireless Receiver not responsive

Has anyone else had this issue, either with the Chinese wireless dongle or with the Hofner bass specifically? I opened YARG, had my guitar synced and it wouldn't recognise the controller/receiver in the 5 fret controller options. I plugged in a Wii Les Paul using a crappy Wii > USB cable and it detected the guitar immediately. Re-synced the Hofner and it didn't work, but it worked in Clone Hero straight away.

There's no serial number or anything on the receiver but I can give you the hardware IDs if that helps:
VID_045E&PID_02A9&REV_060

(Roadmap) Vocals

Vocals/Mic Roadmap

  • Notes
    • Inharmonic notes
    • Pitched/harmonic notes
    • Harmony parts (multiple mics)
    • Scores
  • Starpower
    • Starpower sections
    • Starpower bar
    • Starpower effects
  • Extras
    • Clapping (#39)

Online Servers

So players can get together and play as a Co-op band and rack up insane scores

Drum notes should not be grouped into chords.

Every individual note in a drums "chord" actually increments the combo on its own rather than when all of the notes in that "chord" are cleared. This also applies to scoring and the total note count of the song.

(Roadmap) Pro-Guitar

Pro-Fret Guitar Roadmap

  • Notes
    • Normal notes
    • Sustain notes (almost there)
    • HOPO notes
    • Slide notes
    • Scores
  • Starpower
    • Starpower sections
    • Starpower bar
    • Starpower effects
  • Extras
    • Guitar solos
    • Big rock endings
  • Difficulty downsampling
    • Easy
    • Medium
    • Hard
  • Controllers

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.