yash-10/periodogram-comparison-optimize-planet-detection

Extreme Value Theory for comparing periodograms: Optimizing future transiting exoplanet surveys

periodogram-comparison-optimize-planet-detection's Issues

Issue with optimal frequency sampling implementation

Ofir mentions that delta_f is not constant when using the optimal frequency sampling, whereas it is constant in the code below, which seems incorrect. period must be replaced with the inverse of the test frequency, so the duty cycle depends on the frequency.

https://github.com/Yash-10/ARPS-Periodogram-Comparison/blob/b124cd895106f774a73a074d6e64a5200e292dde/utils.R#L235-L245

Python implementation?

Anyone wanting to use this code in Python somehow can still do it via the reticulate library. But maybe a Python version will also be helpful. Might be very helpful!

Clarify any confusion between a.out and eebls.so

Remove FAP=1 assignment when period not at expected position [simulation case]

Update README

Our approach was slightly modified recently, so that must now reflect in the README.

Move `checkConditions` into a separate unit test

The presence of checkConditions inside evd was done to ensure some things were as expected. It is a good idea to set it to True. However, it will be more beneficial if it is factored into a separate test script instead of in the evd itself. Maybe some execution time will be saved.

Add a `verbose` option to control printing values

Currently, almost everything is printed at every step, which makes it hard to debug. Instead, make printing optional.

SNR is calculated inadvertently on the standardized periodogram

But we want it to be calculated only on the detrended periodogram. Fix needed.

Using `useStandardization` for bootstrapped series as well?

Similar to the argument when noise is Gaussian, periodograms do not show huge trends, hence it is not needed. But if any trend is present, maybe using detrending will help.

Add tests for extreme value code

Some internal, untidy tests were run. But dedicated testing scripts might be helpful in the longer run.