yausername/youtubedl-lazy

Lazy extractors based build of youtube-dl

youtubedl-lazy's Issues

change submodule remote from gitlab to github

hello @yausername, youtube-dl is back, so auto update not working anymore from gitlab.

The latest version of youtube-dl cannot be used due to an error

hey @yausername, In the last update there is an error when using youtubedl-android

Traceback (most recent call last):
File "/data/user/0/com.yausername.youtubedl_android_example/no_backup/youtubedl-android/youtube-dl/__main__.py", line 19, in <module>
youtube_dl.main()
File "/data/data/com.yausername.youtubedl_android_example/no_backup/youtubedl-android/youtube-dl/youtube_dl/__init__.py", line 475, in main
_real_main(argv)
File "/data/data/com.yausername.youtubedl_android_example/no_backup/youtubedl-android/youtube-dl/youtube_dl/__init__.py", line 465, in _real_main
retcode = ydl.download(all_urls)
File "/data/data/com.yausername.youtubedl_android_example/no_backup/youtubedl-android/youtube-dl/youtube_dl/YoutubeDL.py", line 2059, in download
res = self.extract_info(
File "/data/data/com.yausername.youtubedl_android_example/no_backup/youtubedl-android/youtube-dl/youtube_dl/YoutubeDL.py", line 791, in extract_info
if not ie.suitable(url):
File "/data/data/com.yausername.youtubedl_android_example/no_backup/youtubedl-android/youtube-dl/youtube_dl/extractor/lazy_extractors.py", line 2085, in suitable
return False if YoutubeIE.suitable(url) else super(
File "/data/data/com.yausername.youtubedl_android_example/no_backup/youtubedl-android/youtube-dl/youtube_dl/extractor/lazy_extractors.py", line 5612, in suitable
qs = parse_qs(url)
NameError: name 'parse_qs' is not defined

When building youtube-dl manually there is no such error.
I don't know the reason, but I think the problem is in this line

youtubedl-lazy/release.sh

Line 116 in 950f9ca

make lazy-extractors

You can leave it as a comment and rebuild youtube-dl. You will not see the previous error when using it.

--merge-output-format

hello~
request.addOption("-f", "bestvideo+bestaudio");
request.addOption("--merge-output-format", "mkv");
This file is created by separating mp3, mp4 sound and video.
this is working before.
why I don't konw.
maybe it's problem youtubedl binay data or ffmpeg.

2020.03.01 release has no assets

this causes the application to force stop upon checking for update.

Re-enable lazy extractors

Do we have to Re-enable lazy extractors?
See ytdl-org/youtube-dl#28780
Please take a look at these two commitments ytdl-org/youtube-dl@3229030 ytdl-org/youtube-dl@c4a451b

Also i have tested it and it works https://github.com/xibr/youtubedl-lazy/releases/tag/2021.04.26

@yausername Can you take a look at this when you have time?

failed to patch embedthumbnail.py

hi @yausername

after youtube-dl change embedthumbnail.py file, patching file not working.

### patching in files for youtubedl-android support
patching file youtube-dl/youtube_dl/postprocessor/ffmpeg.py
patching file youtube-dl/youtube_dl/postprocessor/embedthumbnail.py
Hunk #1 FAILED at 56.
1 out of 1 hunk FAILED -- saving rejects to file youtube-dl/youtube_dl/postprocessor/embedthumbnail.py.rej