ychennay/diningapplication

This is the code base for the Connoisseur Dining Application, which is our CS130 Software Engineering team project. We are implementing the backend using Spring Boot web services.

diningapplication's Issues

Remove the credential from source code

This is a bad practice. Don't checkin any unencrypted credential into source code
https://github.com/ychennay/DiningApplication/blob/master/src/main/java/dao/DynamoClientMapper.java#L41

Actually Amazon AWS scanned this, and suspend the dev account's api key already, but please remove this from code ASAP lol.

Consider any of following solutions for credential:

• Use your own property file, under your home folder rather than part of repository
• Save encrypted credential, but make sure you save the encryption key in a safer place(or use KMS)
• Use environment variable instead of property lines
  check my example https://github.com/rayxiaonet/connoisseur-ws-account/blob/master/README.md ,which injected via environment variable spring.application.json
  java -Dspring.application.json= '{"spring.profiles.active":"qa","spring.datasource.username":"xxxx", "spring.datasource.password":"xxx"}' -jar connoisseur-account-service-0.0.1-SNAPSHOT.jar
  more details can find from https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html