ydogandjiev/taskmeow

A minimalist todo list app for the enterprise

taskmeow's Issues

Refreshing token workflow

I was wondering if you could point me as to how to implement the Refreshing of the token once the SSO expires (2 hours in)? I found a general flow for the refresh in : https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-implicit-grant-flow

But, in your example the Auth Service calls fetch without any provisions for the token being expired. I wrapped the fetch in a try/catch and did a gettoken which seem to work as a new token is recieved but the backend will not accept it.

thanks

How do you ensure the user is in teams ?

I want to use teams sso as well for my teams tab application so your taskmeow is a perfect example for that. However I don't understand how do you check wether the application executes in teams or not.

I have seen that you are checking a query param inTeams, does the url always have this query param when executing in teams ? How will microsoftTeams.authentication.getAuthToken behaves outside a teams context ?

What I want is for my application only to works inside teams to that anyone accessing directly my web application through a browser won't have access to the data. Any idea how ?

resourceRequiresConsent error when trying to use SSO

Hi. Im following this article where this repo is linked https://docs.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/authentication/auth-aad-sso

And when Im uploading the app to the teams Im getting Error description:AADSTS65001: The user or administrator has not consented to use the application with ID '5e3ce6c0-2b1f-4285-8d4b-75ee78787346' named 'Microsoft Teams Web Client'. Send an interactive authorization request for this user and resource. and resourceRequiresConsent and this point I was expecting to get the native teams popup to get user consent? Am I missing smth? AAD app is configured based on this tutorial and Im calling microsoftTeams.authentication.getAuthToken do I still need to use adal.js when the getAuthToken is rejecting the Promise?

ExtensionTabService: getAuthTokenForApp: Failed with error - App resource defined in manifest and iframe origin do not match

Hi,
I followed the steps mentioned in this page to get a single sign-on functionality for my custom tab in MS Teams. But I get the following error and I could not find out the reason for the same. I re-checked the resource URL used in both manifest as well as App registration page.

ExtensionTabService: getAuthTokenForApp: Failed with error - App resource defined in manifest and iframe origin do not match

Question and possible issue

I have stumbled upon this app in my quest to understand AAD auth within MS Teams tab. I am not sure if my test scenario is valid but want to ask about it still as i experienced the same behavior with my code:

The app opens a popup when used within a browser but, as soon as its in MSTeams Tab instead of a popup, a new Tab is opened in a Browser then the authentication happens there and doesnt make it back to MSTeams.

I have tested this TaskMeow by creating a Website tab of the Demo app and i see the same behavior there. As soon as i click on the login a new tab is opened in my computers' default browser. Is this a valid test scenario? an issue with Teams?

Adal issue happening which i believe is blocking silent auth

Hi @ydogandjiev and thank you for your comment. I was able to install as per the instructions and can log in. What i noticed is that the app receives this error, which basically blocks the silent login feature. I have seen this in the official Complete Node example as well:
From console:

adal.min.js:2 Uncaught TypeError: Cannot read property 'length' of undefined
at AuthenticationContext.getRequestInfo (adal.min.js:2)
at AuthenticationContext.handleWindowCallback (adal.min.js:2)
at silent-end:13

silent-end:13 = ' authContext.handleWindowCallback(window.location.hash);

Googling the Error itself leads to comments stating ADAL is not being worked on anymore and that one should MSAL and is basically a dead-end. Is MSAL the way to go with MSTeams tabs in 2020? everything about the documentation of MSTeams suggests that it is not and ADAL is still the way to go. thanks and apologies if im barking up the wrong tree. Thanks for the demo app :)

Originally posted by @icatchx22i in #28 (comment)

AADSTS90027-error on log-in.

The following error occurs on log-in. A redirect route and app registration is configured properly.

invalid_request: AADSTS90027: We are unable to issue tokens from this API version on the MSA tenant. Please contact the application vendor as they need to use version 2.0 of the protocol to support this.