yearn/vaults

vaults's Issues

Introduce a smart contract automated auditing service like MythX

Description

MythX provides automated security audits and is integrated with the testing framework in this repo: eth-brownie. It's also used by Aave.

It would require monthly fees, which perhaps can be proposed to be paid for by the treasury.

Unable to deposit into yVaults

For the past few days been trying to do my second deposit into the yCRV vault

The first one i did went fine, approved my spending limit, then sent the deposit

This time however metamask is acting weird
Firstly when i went to deposit it asked me to approve a spending limit again, even though i was depositing an amount less than the limit already set from the first deposit. I confirmed the transaction anyway and then it let me do the deposit step except this time the gas fees where somewhere around $500

I thought maybe it was a limit issue so I reduced the amount to deposit to 1, just to test. The transaction was acting normal and metamask was showing a fee of around $4. So I tried again with a higher amount, 100. Again fine. So I went higher, and higher and higher until I got to 970. And for some reason that was the limit. If I tried to deposit 971 it would error. Less was ok. So I deposited the 970, thinking that that was my limit for some reason.

The very next attempt I put in the balance which was 600. Nope error. I tried 1. Error. No matter what number I put in, it didnt work.

I tried using nifty instead of metamask and also tried depositing directly via etherscan....all result in the same issue
I can however use etherscan to set my spending limit successfully. So to me it seems that the issue lies with the deposit function because meta mask works on uniswap for me, and etherscan lets me change spending limits.

In the javascript console on chrome it shows me errors. These error occurs using the yearn website and etherscan.

inpage.js:1 MetaMask - RPC Error: header not found {code: -32000, message: "header not found"}
asyncToGenerator.js:6 Uncaught (in promise)

Im happy to provide wallet or txid via DM if required.

How can deploy the project to testnet?

inCaseStrategyGetStruck

StrategyControllerV2.sol function name (inCaseStrategyGetStruck) - should it be inCaseStrategyGetStuck?

https://github.com/iearn-finance/vaults/blob/211f85b87f7a52c44c93e5e9a227372aef71c070/contracts/StrategyControllerV2.sol#L100

Just wanted to highlight this in case it was a crucial misspelling error

PS. Huge fan of AC & Yearn