yearofmoo/angularjs-seed-repo

angularjs-seed-repo's Issues

Update for Protractor 1.0

Protractor 1.0.0-rc1 is out now - would be good to have a working seed for testing with this. I've tried to run an npm update in the package but have had some issues.

At the moment I've got the following error when running grunt test :

Error: Angular could not be found on the page http://localhost:9999/# : retries looking for angular exceeded

It seems there's now an issue with the test server. If anyone with more experience with protractor/this angular seed has an idea where I'm going wrong, I'd be very pleased to hear.

autotest:e2e

Any idea whats causing this?

Env.

• windows 7 64 bit
• protractor latest (0.14.0)
• selenium web driver 2.37.0
  "webdriverVersions": {
  "selenium": "2.37.0",
  "chromedriver": "2.7",
  "iedriver": "2.37.0"
  },

Proposal (Gulp vs Grunt)

I worked from this example and have something working using Gulp instead of Grunt. Other than that it does the same things. Would you be interested in a Gulp version?

Can't run the development server and autorun tests at the same time

I know I could open two terminals, but shouldn't I be able to do both with one command?

source maps

Hi mate, quick question. Will source maps work correctly with the way you have the concat task setup? If it's all in one file how will it know?

npm ERR! peerinvalid The package protractor does not satisfy its siblings' peerDependencies requirements!

Hello,

When I run npm install after pulling your code, I got the following error:
"npm ERR! peerinvalid The package protractor does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants protractor@~0.10.0"

What I changed is:

1. Open package.json
2. Update "protractor": "latest" to:
   "protractor": "~0.10.0"

That did the trick. I guess latest was using something different that other dependencies don't work with.

Command grunt coverage does not serve index.html with code coverage

When I do a grunt coverage I get this:

grunt coverage
Running "karma:unit_coverage" (karma) task
INFO [karma]: Karma v0.10.4 server started at http://localhost:9876/
INFO [launcher]: Starting browser Chrome
INFO [Chrome 30.0.1599 (Linux)]: Connected on socket zdMgCyO0juSnnOsO9x0F
Chrome 30.0.1599 (Linux): Executed 2 of 2 SUCCESS (0.222 secs / 0.037 secs)

Running "open:coverage" (open) task

Running "connect:coverage" (connect) task
Waiting forever...
Started connect web server on 127.0.0.1:5555.

The browser opens up in localhost:5555 with this message: Cannot GET /.

The output of code coverage does get created in coverage directory, the only problem is that localhost:5555 is serving coverage/ directory, but the output is in coverage/Chrome 30.0.1599 (Linux).

bower and karama-requirejs versions are incorrect, which make "npm install" failed

env

mk@mk-xiaoblack:/dev/karma_trial/angularjs-seed-repo$ npm -v
2.12.1
mk@mk-xiaoblack:/dev/karma_trial/angularjs-seed-repo$ node -v
v0.12.2

fix

mk@mk-xiaoblack:~/dev/karma_trial/angularjs-seed-repo$ git diff
diff --git a/package.json b/package.json
index 13cfacf..733e6ef 100644
--- a/package.json
+++ b/package.json
@@ -14,13 +14,13 @@
"grunt-contrib-watch": "~0.5.3",
"grunt-contrib-concat": "~0.3.0",
"grunt-open": "~0.2.2",

• "bower": "~1.2.6",
• "bower": "~1.3.6",
  "karma-script-launcher": "~0.1.0",
  "karma-firefox-launcher": "~0.1.0",
  "karma-chrome-launcher": "~0.1.0",
  "karma-html2js-preprocessor": "~0.1.0",
  "karma-jasmine": "~0.1.3",
• "karma-requirejs": "~0.1.0",
• "karma-requirejs": "~0.2.0",
  "karma-coffee-preprocessor": "~0.1.0",
  "karma-phantomjs-launcher": "~0.1.0",
  "karma-coverage": "~0.1.0",

reason/issue - 1 - bower 1.2.6 has bug when "bower install", uses 1.3.6 instead

refer to bower/bower#1403

reason/issue - 2 - [email protected] need karma-requirejs 0.2.0, instead of 0.1.0

error msg
mk@mk-xiaoblack:~/dev/karma_trial/angularjs-seed-repo$ npm install
npm WARN package.json [email protected] No repository field.

npm WARN package.json [email protected] No license field.

[email protected] postinstall /home/mk/dev/karma_trial/angularjs-seed-repo
node ./node_modules/bower/bin/bower install

npm ERR! Linux 3.13.0-44-generic
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.2
npm ERR! npm v2.12.1
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package karma-requirejs does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants karma-requirejs@~0.2.0

npm ERR! Please include the following file with any support request:
npm ERR! /home/mk/dev/karma_trial/angularjs-seed-repo/npm-debug.log

post install script not working

Here is my output:

~/repos/angularjs-seed-repo ⮀ ⭠ master ⮀ npm install
npm WARN package.json [email protected] No repository field.

> [email protected] install /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/grunt-shell-spawn/node_modules/execSync
> node install.js

[execsync v1.0.2] Attempting to compile native extensions.
[execSync v1.0.2] Native extension compilation successful!

> [email protected] install /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/karma-phantomjs-launcher/node_modules/phantomjs
> node install.js

Download already available at /var/folders/0p/7d4r5xsd42v3vxp8l1nblp1h0000gn/T/phantomjs/phantomjs-1.9.8-macosx.zip
Extracting zip contents
Removing /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/karma-phantomjs-launcher/node_modules/phantomjs/lib/phantom
Copying extracted folder /var/folders/0p/7d4r5xsd42v3vxp8l1nblp1h0000gn/T/phantomjs/phantomjs-1.9.8-macosx.zip-extract-1422567177163/phantomjs-1.9.8-macosx -> /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/karma-phantomjs-launcher/node_modules/phantomjs/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/karma-phantomjs-launcher/node_modules/phantomjs/lib/phantom/bin/phantomjs

> [email protected] install /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/karma/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
  SOLINK_MODULE(target) Release/fse.node: Finished
npm WARN engine [email protected]: wanted: {"node":"0.6.x || 0.8.x"} (current: {"node":"0.10.33","npm":"1.4.28"})

> [email protected] install /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
  SOLINK_MODULE(target) Release/bufferutil.node
  SOLINK_MODULE(target) Release/bufferutil.node: Finished
  CXX(target) Release/obj.target/validation/src/validation.o
  SOLINK_MODULE(target) Release/validation.node
  SOLINK_MODULE(target) Release/validation.node: Finished

> [email protected] postinstall /Users/@f1lt3r/repos/angularjs-seed-repo
> node ./node_modules/bower/bin/bower install

bower angular-animate#1.2.5 not-cached git://github.com/angular/bower-angular-animate.git#1.2.5
bower angular-animate#1.2.5    resolve git://github.com/angular/bower-angular-animate.git#1.2.5
bower jquery#~2.0.3         not-cached git://github.com/jquery/jquery.git#~2.0.3
bower jquery#~2.0.3            resolve git://github.com/jquery/jquery.git#~2.0.3
bower angular-mocks#1.2.5   not-cached git://github.com/angular/bower-angular-mocks.git#1.2.5
bower angular-mocks#1.2.5      resolve git://github.com/angular/bower-angular-mocks.git#1.2.5
bower angular-route#1.2.5   not-cached git://github.com/angular/bower-angular-route.git#1.2.5
bower angular-route#1.2.5      resolve git://github.com/angular/bower-angular-route.git#1.2.5
bower angular#1.2.5         not-cached git://github.com/angular/bower-angular.git#1.2.5
bower angular#1.2.5            resolve git://github.com/angular/bower-angular.git#1.2.5
bower angular-animate#1.2.5      error Arguments to path.join must be strings

Stack trace:
TypeError: Arguments to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at GitHubResolver._checkout (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/lib/core/resolvers/GitHubResolver.js:54:21)
    at /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/lib/core/resolvers/GitResolver.js:69:21
    at _fulfilled (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:798:54)
    at self.promiseDispatch.done (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:827:30)
    at Promise.promise.promiseDispatch (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:760:13)
    at /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:574:44
    at flush (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:108:17)

Console trace:
Trace
    at StandardRenderer.error (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/lib/renderers/StandardRenderer.js:74:17)
    at Logger.updateNotifier.packageName (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/bin/bower:109:18)
    at Logger.emit (events.js:95:17)
    at Logger.emit (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/bower-logger/lib/Logger.js:29:39)
    at /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/lib/commands/install.js:27:16
    at _rejected (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:808:24)
    at /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:834:30
    at Promise.when (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:1079:31)
    at Promise.promise.promiseDispatch (/Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:752:41)
    at /Users/@f1lt3r/repos/angularjs-seed-repo/node_modules/bower/node_modules/q/q.js:574:44

System info:
Bower version: 1.2.8
Node version: 0.10.33
OS: Darwin 14.0.0 x64

npm ERR! [email protected] postinstall: `node ./node_modules/bower/bin/bower install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is most likely a problem with the yearofmoo-angularjs-seed-repo package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./node_modules/bower/bin/bower install
npm ERR! You can get their info via:
npm ERR!     npm owner ls yearofmoo-angularjs-seed-repo
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 14.0.0
npm ERR! command "/Users/@f1lt3r/local/bin/node" "/Users/@f1lt3r/local/bin/npm" "install"
npm ERR! cwd /Users/@f1lt3r/repos/angularjs-seed-repo
npm ERR! node -v v0.10.33
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/@f1lt3r/repos/angularjs-seed-repo/npm-debug.log
npm ERR! not ok code 0

Preprocessors in `unit-coverage` break when present in karma.conf too

My karma-unit.conf.js file which started-off this seed, now looks like:

    files: [
      ...
      'app/views/*.html'
    ],
    preprocessors: {
      'app/views/*.html': ['ng-html2js']
    },
    ngHtml2JsPreprocessor: {
      moduleName: 'views',
      stripPrefix: 'app/'
    }

I was running grunt:karma:unitCoverage and I kept getting errors like:

Chrome 32.0.1700 (Mac OS X 10.9.2) ERROR
    Uncaught SyntaxError: Unexpected token <
    at /Users/myUsername/dev/nyApp/app/views/home.html:1

After much trial and error I figured out the way to fix this was to embellish the Gruntfile.js with the preprocessor that had been sitting in karma-unit.conf.js:

    karma: {
      unitCoverage: {
        configFile: './test/karma-unit.conf.js',
        preprocessors: {
          'app/scripts/*.js': ['coverage'], 
          'app/views/*.html': ['ng-html2js'] // had to be repeated here
        }

Is this because the preprocessor block is getting overridden?

Another suggestion is to alter the seed such that subdirectories would be covered too:

        preprocessors: {
          //'app/scripts/*.js': ['coverage'], // original
          'app/scripts/**/*.js': ['coverage'], // may be a nicer default
          'app/views/*.html': ['ng-html2js']
        }

coverage folder not generated

git clone https://github.com/yearofmoo/angularjs-seed-repo.git
npm install -g grunt-cli
npm install
grunt install
grunt coverage
Coverage folder is not generated

git clone https://github.com/yearofmoo/angularjs-seed-repo.git
npm install -g grunt-cli
npm install
grunt install
grunt test:coverage
Coverage folder is not generated

I'm not sure if it's an NPM thing but it seems karma coverage is broken? I noticed this when cloning my own project with a fresh npm install and coverage not working too.

Any ideas?

Syntax Error

No idea what's going on and don't have the time to debug this.

node -v
v0.10.25

$ npm install grunt-gulp --save-dev

/usr/share/npm/node_modules/npm-registry-client/lib/tag.js:1
(function (exports, require, module, __filename, __dirname) {
^
SyntaxError: Unexpected token ILLEGAL
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at /usr/share/npm/node_modules/npm-registry-client/index.js:70:49
at Array.forEach (native)
at Object. (/usr/share/npm/node_modules/npm-registry-client/index.js:68:47)
at Module._compile (module.js:456:26)

SyntaxError: Unexpected token ILLEGAL at Installation,after npm install

I am getting this error after npm install while installing the app
I will appreciate anyone's help

> yearofmoo-angularjs-seed-repo@ postinstall D:\uvhosts\rest.dev\apps\angularjs-
seed-repo
> node ./node_modules/.bin/bower install


D:\uvhosts\rest.dev\apps\angularjs-seed-repo\node_modules\.bin\bower:2
basedir=`dirname "$0"`
        ^
SyntaxError: Unexpected token ILLEGAL
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3
npm ERR! weird error 8
npm ERR! not ok code 0

Running grunt autotest:e2e reported .\selenium\start is not recognized

Hello,

This is not a issue report but I'm curious as when I run autotest:e2e command, I got the following (with error):

"Running "connect:testserver" (connect) task
Started connect web server on 127.0.0.1:9999.

Running "shell:selenium" (shell) task

Running "watch:protractor" (watch) task
Waiting...>> '.\selenium\start' is not recognized as an internal or external command,

operable program or batch file.
Warning: Done, with errors."

Why am I seeing that error only on initial run?

It is confusing as I thought there was a failure at first.

Anyway, even with the error and the screen looked like it hung, if I make changes to the app or the test files, I see browser being opened and tests run correctly.

My system is a Windows 7.