Giter Site home page Giter Site logo

Comments (8)

growupanand avatar growupanand commented on August 13, 2024

@Yeasir0032 Assign the issue so that I can start working on it.

from discord-clone.

growupanand avatar growupanand commented on August 13, 2024

@Yeasir0032 do you agree with below solution?

We can upload the image immediately when the user clicks the "create" button, providing a better user experience than uploading the image first and then creating the server by clicking on the "create" button.

from discord-clone.

Yeasir0032 avatar Yeasir0032 commented on August 13, 2024

Actually this is handled with uploadthing
Do check it if you really can do it

from discord-clone.

growupanand avatar growupanand commented on August 13, 2024

@Yeasir0032 There are two points below that I want to discuss with you:

  • Showing preview before upload
    You are using <UploadDropzone from "@uploadthing/react" for handling the whole file selection and upload flow. As per my knowledge after reading its documentation, there is no way to get the currently selected file before uploading it.
    Solution - Instead of relying on <UploadDropzone for image upload flow, we can use useUploadThing like here. This way we have full control of the upload flow.
    Reference -

  • Showing preview after upload
    While we implement a custom image upload flow which can take some time, I can fix showing the uploaded image preview.
    Reference -

    if (value && fileType === "image") {

from discord-clone.

Yeasir0032 avatar Yeasir0032 commented on August 13, 2024

Check issue 10. It is working on to replace upload thing

from discord-clone.

growupanand avatar growupanand commented on August 13, 2024

Until new upload service #10 is implemented,
Should I fix Showing preview after upload for the current upload flow?
Or just wait for the new upload service?

from discord-clone.

Yeasir0032 avatar Yeasir0032 commented on August 13, 2024

You can wait

from discord-clone.

growupanand avatar growupanand commented on August 13, 2024

<UploadDropzone component now supports onDrop prop.

FYI - pingdotgg/uploadthing#809

from discord-clone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.