yebblies/magicport2

magicport2's Issues

building from newmagic branch

As in title, i'm building from newmagic branch in your dmd fork, using win32.mak ddmd (this was just a convenient place to raise issue).

Had some issues building:

https://github.com/D-Programming-Language/dmd/blob/master/src/mars.c#L142 has an #include directive in the expression, which the magicport parser doesn't like. I hard-coded a version to work around.

Some string literals like: https://github.com/D-Programming-Language/dmd/blob/master/src/doc.c#L132 have unterminated back-slashes, to escape the line endings. DMD didn't like it, so in dprinter.d, I added a string escaper to the LitExpr visitor:

override void visit(LitExpr ast)
{
    if (ast.val.endsWith("L", "l"))
    {
        print(ast.val[0..$-1]);
    } else {        
        print(escapeBackslash(ast.val));
    }
}

auto escapeBackslash(string s) {
    import std.regex;   
    return s.replaceAll(regex(`\\\r\n`), ``);
}

which doesn't actually escape the string, it just removes the unterminated char constants.

Anyhoo, I'm wondering how you build this make target, if you are not seeing these issues, or is magicport in the newmagic branch not up to date, or am I missing some dmd patches?

cheers

nonFinalClass not in settings.json

I just tried to run magicport on dmd but It gets range violations because there are fields missing in settings.json