yeedle/2048

2048 JavaFX version

Hi there!

I am...

• 🙂 Abraham "Yeedle" Neuwirth (he/him)
• 💻 proficient in Python, Java/C#, and Javascript/TypeScript, SQL, and a dabbler in many other languages
• 🖥️ Highly experienced with Vue.js, ReactJS, NestJS, Express.js, FastAPI, PostgreSQL and many more
• 🔬 I’m currently working as a full stack software engineer at Formation Bio
• 🌱 I’m currently learning Go
• 📫 Reach me by email or linkedin

2048's Issues

Test issues

Hello world

Values after shifts are incorrect

As @yeedle noticed, my current algorithm doesn't provide the correct values for tiles that were moved via the shiftZeros() method. The core of the issue is that in order for my mergeRow() algorithms to work I implemented shiftZeros() so that it swaps the actual tile on the grid and not just the value. The problem is, since it only swaps the reference to the tile, the tiles are not actually swaped from the GUI's perspective.

To address this issue, I decided that the most straight-forward, efficient approach would be to code an algorithm that would shift and merge tiles in one pass. Although it will increase the code's complexity, it will be the simplest (and most efficient) approach to allow values to be merged and shifted between tiles while marking the correct transition values in the original tile.

What do you think, @yeedle?

Arc Height and Width

Every tile has an arc height and an arc width, which is very similar to the border-radius property of CSS. In the original implementation a border radius of 3px is used. Should we keep it as close to the original as possible, or should we make it more sleek looking by rounding the edges? What do you think, @modicohen?

Rotating the board as a method for movements

It makes the code much clearer and less complicated. However, it might be too heavy for smooth processing since every movement besides 'left' will cause the board to rotate 4 times. It is something that we will have to test. What say you, @yeedle ?