yermo/geophpwithfeatures

Advanced geometry operations in PHP with Features Data

geophpwithfeatures's Issues

& in metadata tags generates incorrect file

Adding a & or other illegal characters into names or other meta data generates an incorrect file.

GeoJSON representation of a route point extension should be a geojson linestring.

Currently, when exported to our extended GeoJSON format, the route point extension which describes the points between two route way points is a list of coordinates with some metadata. This is awkward.

It should be represented as a line string feature with its own geometry and properties keys.

GPX files generated with geoPHPwithFeatures cannot be imported into Garmin Basecamp

Garmin Basecamp raises an "invalid GPX file" error when attempting to import GPX files created with this library. It appears that the tags under metadata have to be in a specific order.

Converting GPX waypoints without a name to geojson generates a bad point.

<wpt lat="39.684955555556" lon="-77.468375" />`

when converted to geojson yields:

"features" : [ { "type" : "Point", "coordinates" : [ -77.468375, 39.684955555556, null ] },

Note the missing geometry key.

Support mbymc GPX extensions

Add support for the Miles By Motorcycle GPX extension.

Register fork on Packagist

Did you think about registering the fork on an own namespace on Packagist ?

Conversion of a single geometry from GPX to JSON and back again loses data.

Converting the following GPX file to geojson:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
  <metadata>
    <link href="http://www.garmin.com">
      <text>Garmin International</text>
    </link>
    <time>2013-05-27T17:23:57Z</time>
  </metadata>
  <wpt lat="35.466436" lon="-83.920083">
    <ele>573.07</ele>
    <name>Deals Gap</name>
    <sym>Waypoint</sym>
  </wpt>
</gpx>

becomes:

{
   "properties" : {
      "link" : [
         {
            "text" : "Garmin International",
            "href" : "http://www.garmin.com"
         }
      ],
      "time" : "2013-05-27T17:23:57Z"
   },
   "type" : "FeatureCollection",
   "features" : [
      {
         "properties" : {
            "name" : "Deals Gap",
            "sym" : "Waypoint",
            "elevation" : "573.07"
         },
         "geometry" : {
            "coordinates" : [
               -83.920083,
               35.466436,
               573.07,
               {
                  "elevation" : "573.07"
               }
            ],
            "type" : "Point"
         },
         "type" : "Feature"
      }
   ]
}  

Converting it back to GPX yields:

<?xml version="1.0"?>
  <metadata>
    <time>2013-05-27T17:23:57Z</time>
  </metadata>
  <wpt lat="35.466436" lon="-83.920083">
    <time>2013-05-27T17:23:57Z</time>
  </wpt>
</gpx>  

Store a complete Feature entry as a route waypoint

Currently, an abbreviated properties object is included as the fourth position in the route coordinates array.

{
   "features" : [
      {
         "geometry" : {
            "type" : "LineString",
            "coordinates" : [
               [
                  -77.463442,
                  39.526728,
                  null,
                  {
                     "extensions" : {
                        "gpxx_routepointextension" : [
                           [
                              "-77.463442",
                              "39.526642"
                           ],
                           [
                              "-77.463056",
                              "39.526620"
                           ],

This is proving to be inconvenient.

Modify this to store a complete Point Feature in this position to mirror a waypoint entry. The only difference between a standalone waypoint marker entry and this copy will be the presence of the gpxx_routepointextension coordinate array.

e.g.:

               "geometry" : {
                  "coordinates" : [
                     [
                        -83.92005443573,
                        35.466550939862,
                        null,
                        {
                           "name" : "Unnamed",
                           "properties" : {
                              "cmt" : "This is a comment about the Deal's Gap Start Point",
                              "name" : "Deals Gap Start" 
                              "link" : [
                                 {
                                    "href" : "http://dealsgap.com "
                                 }
                              ],
                              "desc" : "This is a test of the deals gap start waypoint",
                              "extensions" : {
                                 "gpxx_routepointextension" : [
                                    [
                                       -83.920013,
                                       35.466556
                                    ],
                                    [
                                       -83.920028,
                                       35.467197
                                    ],

Getting empty output on GEOJSON -> GPX

I am getting an "empty" (no features in it) GPX output on the attached file.

654.geojson.txt

php geo_convert.php --input-path=../../654.geojson --input-format=geojson --output-path=../../654.gpx --output-format=gpx

Latest commit breaks GPX Export

The order of elements in GPX export is once again incorrect.

Fix it and add a test to make sure the GPX files generated validate.

HTML entities in metadata cause an invalid GPX file to be generated.

<desc>A stone's throw</desc>

Where the ' is an ’ causes an invalid GPX file to be generated.

GeoJSON representation of markers duplicates data.

The GeoJSON representation of a GPX marker duplicates properties under as a fourth entry into the coordinates array.