yomimono/charrua-client

former home of Charrua client code

charrua-client's Issues

mirage dhcp client should log the obtained lease

It's useful to see the lease information when one has been obtained. This should be logged, probably at level info.

random tests aren't really testing the library

See

charrua-client/lib_test/test_client.ml

Line 34 in 9b689fb

(* TODO: it would be better to randomize a valid DHCP message; currently

. Unless we have the great good fortune to accidentally generate a buffer that contains valid Ethernet, IP, and UDP layers, we don't even get to the point of testing the DHCP parser, let alone proper processing of the packet by our own code. We should instead generate a random Dhcp_wire.pkt and send that to Dhcp_wire.pkt_to_buf to create the input for random tests.

See also mirage/ocaml-cstruct#114 .

an interface for lease renewal should exist

Currently, the only supported code path is a complete lease transaction from cold start. We should at least provide an interface for renewing a lease given the information from the last completed lease transaction.

merge this repository's code into charrua-core

Charrua-client (and charrua-client.mirage) could be instead a sublibrary of charrua-core, like charrua-core.server.