yortus/rtti

Runtime type information for JavaScript and TypeScript programs

rtti's Issues

[BUG] removeExcessProperties doesn't work properly for nested intersections

Code ref: https://github.com/yortus/rtti/blob/master/src/remove-excess-properties.ts#L32-L36

If t contains members that are themselves intersections, then those intersections' members should also end up in combinedProps, but with this code they don't. This means too many props get removed in some cases.

Need to flatten intersections for the purposes of the removeExcessProperties function.

Should check if this affects other functions too.

`sanitize` doesn't work well with nested objects in intersections

Source code in question: https://github.com/yortus/rtti/blob/main/src/operations/sanitize.ts#L30-L40

This current implementation works for simple intersections of objects, but not nested objects. It basically removes all properties of nested objects except those defined in the last member of the intersection.

To rectify this, it should do a 'deep' intersection of nested properties first, and then delegate to object sanitisation.

Rtti uses `util` causing issues in Webpack 5

HI @yortus :)

We are using your other lib, http-schemas, that relies on rtti. We are using this in a browser SPA that relies on Webpack 5. Webpack 5 has stopped providing polyfils for some node based libraries like util. Is it possible to change the requirement of this library away from using util?

RR! Module not found: Error: Can't resolve 'util' in '/Users/ray/source/xxx/shared/http/node_modules/rtti/dist/commonjs'
ERR! 
ERR! BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
ERR! This is no longer the case. Verify if you need this module and configure a polyfill for it.
ERR! 
ERR! If you want to include a polyfill, you need to:
ERR! 	- add a fallback 'resolve.fallback: { "util": require.resolve("util/") }'
ERR! 	- install 'util'
ERR! If you don't want to include a polyfill, you can use an empty module like this:
ERR! 	resolve.fallback: { "util": false }
ERR! ModuleNotFoundError: Module not found: Error: Can't resolve 'util' in '/Users/xxx/shared/http/node_modules/rtti/dist/commonjs'
ERR!