Giter Site home page Giter Site logo

Comments (7)

youhosi avatar youhosi commented on May 18, 2024

@tom-rade In which case, what color would be appropriate in your opinion?

from nodebb-theme-oxide.

tom-rade avatar tom-rade commented on May 18, 2024

@youhosi Something like #303030 or maybe a tad lighter with #444444

from nodebb-theme-oxide.

youhosi avatar youhosi commented on May 18, 2024

@tom-rade #303030 and #444444 is too dark and would stand out too much in the template.

from nodebb-theme-oxide.

tom-rade avatar tom-rade commented on May 18, 2024

@youhosi Hmm yeah, the theme is indeed pretty light. But most #bbb classes should be changed so it gets normalized. Otherwise I'd try using #7c7c7c, that would still be more readable than #bbb. But #bbb is way too light and unreadable.

from nodebb-theme-oxide.

youhosi avatar youhosi commented on May 18, 2024

@tom-rade To set a darker color in these classes, the whole style would have to be adapted from the beginning.

@gray-base:              #444444;
@gray-darker:            lighten(@gray-base, 13.5%); // #666
@gray-dark:              lighten(@gray-base, 20%); // #777
@gray:                   lighten(@gray-base, 33.5%); // #999
@gray-light:             lighten(@gray-base, 37%); // lighten(@gray-base, 46.7%); // #bbbbbb
@gray-lighter:           lighten(@gray-base, 65%); // #eaeaea

from nodebb-theme-oxide.

tom-rade avatar tom-rade commented on May 18, 2024

@youhosi Yep, but I find it is necessary. #bbb is waaaay too light. Text should be black (even here on GitHub, on a light theme - it's black) - not gray.

from nodebb-theme-oxide.

youhosi avatar youhosi commented on May 18, 2024

@tom-rade All in all a fact, so you will need to work on the color style. Do you have any suggestions regarding colors? Take into account that they also can not stand out too much from the rest of the elements.

I also thought about adding an underline when hovering on a link.

from nodebb-theme-oxide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.