Giter Site home page Giter Site logo

nodebb-theme-oxide's People

Contributors

barisusakli avatar chocho13 avatar dependabot[bot] avatar doppelganger237 avatar oplik0 avatar telonko avatar xeon999 avatar youhosi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

nodebb-theme-oxide's Issues

[BUG] Topic openning post weird UI on mobile

**Smartphone ( android )

  • **NodeBB version: 1.31
  • **NodeBB git hash: c6ef1486dee5cfb0d435716cf7d4d718fad68359
  • **Device:Xiaomi Redmi Note 8 Pro
  • **OS:Android 9.0 (Pie); MIUI 10
  • **Browser:Chrome

First post in the topic, has very weird UI. A lot of empty space.


Additional context / Screenshots
https://ibb.co/3Ymsyvc

[BUG] Navigation Links + Search Bar.

Desktop: (please complete the following information)

  • NodeBB version: Latest 1.3.x
  • NodeBB git hash: ? (git rev-parse HEAD)
  • Device: Chrome
  • OS: Windows 10
  • Browser:

Describe the bug
When you add extra Links to the Navigation Plane, it pushes the whole Navigation bar to under the logo/forum name. This wouldnt be an issue except the header itself isnt set to extend, so the header hides the forum navigation as well as the top of custom pages.

I also noticed this on the default set of navigation icons, except it only drops down when you go to a forum thread, and the comment navigation is added to the top header as well.


Additional context / Screenshots
https://i.imgur.com/CyrHKaC.png
https://i.imgur.com/WZNMtdT.png

[BUG] Duplicated sidebars / (popup) invalid data in profile

Smartphone / Desktop: Desktop

  • NodeBB version: 1.12.2
  • NodeBB git hash: 22db818eb40f04e528d95257c5517ded8341493d
  • Device: ------
  • OS: Windows 10
  • Browser: Brave

Describe the bug
All sidebars are duplicated, and on profile page when sidebars enabled jump popup "invalid data"

Additional context / Screenshots
http://prntscr.com/ov3m62
http://prntscr.com/ov3mnd
and one question is, how to add sidebars only on specific page e.g. like umod.pl?
No translate for
pages:account/latest-posts, nick
No group badge in topic view

No license is specified

This theme doesn't specify any code license, which means there are quite a few copyright problems possible here. To quote choosealicense.com:

When you make a creative work (which includes code), the work is under exclusive copyright by default. Unless you include a license that specifies otherwise, nobody else can copy, distribute, or modify your work without being at risk of take-downs, shake-downs, or litigation. Once the work has other contributors (each a copyright holder), “nobody” starts including you.

And the last part has already happened here: there are two other contributors to this project and any one is full copyright holder to his own contributions.

If the project is supposed to be as open as possible, I think the best license would be MIT License. If you want to force all forks and code using this theme also being open source, GPLv3 is probably the best "viral" license.

module not found

 nodebb git:(master) npm install node-theme-oxide@latest
npm ERR! code E404
npm ERR! 404 Not Found: node-theme-oxide@latest

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-02-19T13_06_38_776Z-debug.log

Sidebar is over footer ( at the bottom )

Smartphone / Desktop: (please complete the following information)

  • **NodeBB version:1.13.2
  • **Device: all different
  • **OS: all different
  • **Browser: all different

Looks like after update sidebar widgets are just over the footer, the bottom not at the right side.

Additional context / Screenshots

https://imgur.com/a/ZDMql9P

Small badge problem

Hello,
When you put a group in invisible to prevent it from being seen in the list, the group's badge is not displayed on the profile
For example I'm in the admin group which is invisible but I'm looking to display the badge

Thanks

[BUG] Site-wide-conversation?

Smartphone / Desktop: (please complete the following information)
Both

  • NodeBB version:
    1.13.2 (full latest version)

  • NodeBB git hash: (git rev-parse HEAD)
    ?

  • Device:
    Both Windows and Phone, they aren't even important here

  • OS:
    NodeBB is running on Debian 10 on my server.

  • Browser:
    Again, does not matter.


Describe the bug
A clear and concise description of what the bug is.

So...

The bug is that, I am having a Site-wide-conversation in my forum (somewhy), and I can't find a place to disable it. Now... Every time one clicks on that conversation, it says "A new user has renamed the conversation Site-wide-conversation" and it also sends a message to everyone. This happened when I started using the Oxide theme.


Additional context / Screenshots
https://prnt.sc/s9s8of Here you can see the problem.

Steam SSO Intergration Question

Hello!

So I had a question that perhaps you would be knowledgeable enough to be able to assist me with. I have a Steam SSO plugin that allows user to login/register via steam, and it saves their steam profile and steam64 ID to their user info in the mongodb, however it does not display that information on their profiles, as the plugin wasn't made to be able to do that, however for the project I am working on, making that information publicly accessible, as well as make a script that can take their steam64 ID and apply it to additional user links. For TF2, most websites use their 64id as their profile link. so things like rgl.gg/user/steam64. I was wondering if you might know how do this, or at the least, what I would need to edit/do on your theme to be able to display that information.

Thanks, and I appreciate the help!

Dark Theme mode always turned on

Smartphone / Desktop: (please complete the following information)

  • **NodeBB version:1.13.2
  • **Device: all different
  • **OS: all different
  • **Browser: all different

with current version of theme ( with default dark theme off in admin panel ), every user has it on, and when they switch it off, after page refresh it goes back to dark.

[BUG] Page "register/abort" not found

Smartphone / Desktop: Desktop

  • NodeBB version: 1.14.3
  • NodeBB git hash: (git rev-parse HEAD)
  • Device: PC
  • OS: Windows 10
  • Browser: Vivaldi

Describe the bug
Page for abort registration does not work.


Additional context / Screenshots
File registerComplete.tpl from nodebb-theme-persona has special form for cancel registration:

<form role="form" method="post" action="{config.relative_path}/register/abort">
	<p class="text-center">
		<button class="btn btn-link">[[register:cancel_registration]]</button>
	</p>
</form>

File registerComplete.tpl from nodebb-theme-oxide has only link to register/abort. And this link get page 404.
To correct this error, we can simply return a separate form for aborting registration:

<form role="form" method="post" action="{config.relative_path}/register/complete/?_csrf={config.csrf_token}" enctype="multipart/form-data">
	{{{each sections}}}
	<div class="row">
		<div class="col-xs-12 col-sm-8 col-sm-offset-2">
			<div class="panel panel-default">
				<div class="panel-body">
					@value
				</div>
			</div>
		</div>
	</div>
	{{{end}}}

	<div class="row">
		<div class="col-xs-12 col-sm-8 col-sm-offset-2">
			<button class="btn btn-primary btn-block">Submit</button>
			<!-- Remove this code
			<p class="text-center">
				<br />
				<a target="_top" href="{config.relative_path}/register/abort">[[register:cancel_registration]]</a>
			</p>-->
		</div>
	</div>
</form>

<!-- Add this code -->
<form role="form" method="post" action="{config.relative_path}/register/abort">
	<p class="text-center">
		<button class="btn btn-link">[[register:cancel_registration]]</button>
	</p>
</form>

User status position on oxide-usercard

I don't know if thats an issue or not, but I might have found a little css issue on the oxide-usercard:

The online status is located on the top-right corner of the user card body in stead of being located after the user's name starting with an @ (eg. @Eastrall).
image
This is related to the general style applied by the .status that has the following properties:

{
    position: absolute;
    top: 0;
    right: 0;
    vertical-align: 0;
}

Found in this file:

.status {
position: absolute;
top: 0px;
right: 0;
font-size: @font-size-small;
vertical-align: 0;
@media (min-width: @screen-sm-min) {
font-size: @font-size-base;
}
}

I've made some tests and found that if we remove the position, top and right properties, we would have the same behavior has the original nodebb theme. But, it would break the little status icon located near the avatar on the topic template:

image

Another option would be to add a .status property to the usercard.less file so this style would be only applied to the card.

I can do a PR to fix that if you want. Just tell me which solution suits better the needs.

build error

What should I do interms of this error:

["Expression"] but instead got null {"stack":"TypeError: Property consequent of ConditionalExpression expected node to be of a type [\"Expression\"] but instead got null\n    at Object.validate (/root/nodebb/node_modules/babel-types/lib/definitions/index.js:109:13)\n    at validate (/root/nodebb/node_modules/babel-types/lib/index.js:505:9)\n    at Object.builder (/root/nodebb/node_modules/babel-types/lib/index.js:466:7)\n    at Object.OpenIf (/root/nodebb/node_modules/benchpressjs/build/lib/compiler/compiler.js:105:14)\n    at compile (/root/nodebb/node_modules/benchpressjs/build/lib/compiler/compiler.js:146:49)\n    at Object.OpenIter (/root/nodebb/node_modules/benchpressjs/build/lib/compiler/compiler.js:118:246)\n    at compile (/root/nodebb/node_modules/benchpressjs/build/lib/compiler/compiler.js:146:49)\n    at compiler (/root/nodebb/node_modules/benchpressjs/build/lib/compiler/compiler.js:160:20)\n    at compileFallback (/root/nodebb/node_modules/benchpressjs/build/lib/precompile.js:32:17)\n    at Promise.try (/root/nodebb/node_modules/benchpressjs/build/lib/precompile.js:93:88)"}

I only have on Oxide theme now, I am pretty new to frontend and nodejs, could any body help me?

Search page

The current look of the search engine does not match the rest of the page

Todo:

  • Create two rows: first for advanced search, and second for results
  • Result count is header
  • Turn sort (button) into an independent dropdown
  • Changing the appearance of views
  • Improve the code and optimize it
  • Use media queries

(Option to) show all badges on the post and profile by default

According to this issue, the displaying of all badges next to posts and on the profile is possible:

NodeBB/NodeBB#7180
"Display of badges is controlled at the theme level, themes can elect to show all badges, as the data is (or should be, anyway) available for use in templates."

So technically, it should be possible to implement it that way. I'd very much appreciate it and this is the only thing needed for us to switch to this theme.

Custom background image

How Can I add custom background image into your nodebb theme , can't find the css file in your theme folder

[BUG] Quick reply

Smartphone / Desktop: (please complete the following information)

  • NodeBB version: 1.13.2
  • NodeBB git hash: (git rev-parse HEAD) 71f4607db4e2252995d488b1968f7e9bb1d97efc
  • Device:
  • OS:
  • Browser: Chrome / Firefox

Describe the bug
We enable the "quick reply" in the theme option and all our users tell us the same bug/issue. When you quick reply, the text stay in the quick reply box after you send it until you browse another "thread"


Additional context / Screenshots
Add any other context about the problem here.
image

Change color of light gray description and other small texts

The only other thing bothering me, is the colors of descriptions and small texts. For example:

[component="category"] .category-details .content .show-separator .description {
    font-size: 12px;
    color: #bbb;
}

#bbb is way too light on most displays causing the user to barely read anything. Some other CSS classes where it's too light: .categories-title .breadcrumb .categories .category-details

Mobile visual does not looks well

Hi, the theme on mobile shows abnormal, it swapable horizontal which is not good mobile users. Does it a bug or just in my case it show like this? I have test on both iOS and Android devices on chrome. All shows like this. it would be better to make width same as screen width and can not swipe for mobile devices

Second row on subcategories

When you have a lot of subcategories, there should be a new line, instead of a scrollbar. This is currently used in persona and is way more practical. Would also appreciate CSS-snippet to change this if this won't be changed in master.

Width modification

Hi,

First of all, nice job on this theme. With the dark mode too, it's awesome.

But I would have a little request, do you think it's possible to use the full width of the screen for the forum instead of the fixed width ?

[BUG] Quick reply mentions no longer displaying list of selectable people/groups.

Smartphone / Desktop: (please complete the following information)

  • NodeBB version: 1.14.2
  • NodeBB git hash: (git rev-parse HEAD) 28970b030d21a9e839804b0c40e0ed1c520502ac
  • Device: Desktop
  • OS: Windows 10
  • Browser: Firefox 79.0 (x64)

Describe the bug
Mentions in the quick reply no longer show a selectable list of people or groups to mention.

The list still shows up correctly in full composer.


Additional context / Screenshots
N/A

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.