youxin11544 / mvp-rxjava-hybride Goto Github PK

This is an Android MVP model good architecture design，Which also inherited the Android architecture and HTML 5 interaction。（这是一个Android MVP模型良好的架构设计,同时也做了Android和HTML 5交互架构，用到了RxJava+Retrofit+MVP+泛型缩减mvp+模板模式+命令模式+观察者模式+管理者模式 +简单工厂模式）

Java 100.00%

mvp-rxjava-hybride's People

Contributors

Stargazers

Watchers

Forkers

neil-orzzh stevenjj007 issac919 a-how shenshanlaoyuan chenshanze xuruifeng jarvisbuop zhugefubin llpj jdsjlzx ab503044120 wangxiang91 eideo 396386866 tonybrother889 liangmingjie johnmyqin 24kshign zgw199012 zenfer-for-you qiuxian1991 russllgo87 zizheng1989 codingmancui aer874475222 mcq12322 luxiaoming niemj6012 mrn86 xjbclz xiangffgh ziyues yzhixiang huangcv yuanbin3136 xiaolong5477 simplifiedrobot acomet zgkxzx lionszhang xjqx2z jidekun hanmichael joashchn itzujun yuyiwentaojia zzf6868 wutingxi serge66 lingbaeryi ruanchengzhi quwanxin pellinglyu bluearvin springj jiaowenzheng zych-ch hdingmin gslovemy ayo616 mrdavy m45ter yeinfo 2050utopia archie2010 pengjary flyings-sky ryanfu xixinfei mq-d-lufei wolf937 zhangzhun132 sk0806 fhgivn hxy0107 yuanye09 hubeihuk stary-zdc 877898444 codejustfun champagneguo longyuan5 taishanjd longzekai madengtt woospirit777 hgwxr staticstone bigbangbear d9823 jacksonli-libin fendouwangzi gitgzw lostinai a616707902 alan2083 lkwdzh shubing huirong628

mvp-rxjava-hybride's Issues

这个逻辑是不是可以优化一下？？？

public < T > Observable<T> flatResponse(final T response) {
        return Observable.create(new Observable.OnSubscribe<T>() {
            @Override
            public void call(Subscriber<? super T> subscriber) {
                if (response != null) {
                    if (!subscriber.isUnsubscribed()) {
                        subscriber.onNext(response);
                    }
                } else {
                    if (!subscriber.isUnsubscribed()) {
                        subscriber.onError(new APIException("自定义异常类型", "解析json错误或者服务器返回空的json"));
                    }
                    return;
                }
                if (!subscriber.isUnsubscribed()) {
                    subscriber.onCompleted();
                }
            }
        });
    }

将subscriber的判断提取出来

public < T > Observable<T> flatResponse(final T response) {
        return Observable.create(new Observable.OnSubscribe<T>() {
            @Override
            public void call(Subscriber<? super T> subscriber) {
                 if (subscriber.isUnsubscribed()) {
                        return;
                    }
                if (response != null) {
                        subscriber.onNext(response);
                } else {
                        subscriber.onError(new APIException("自定义异常类型", "解析json错误或者服务器返回空的json"));
                    return;
                }
                subscriber.onCompleted();

            }
        });
    }