yunbinmo/pe

pe's Issues

Unable to find client after one unsuccessful find action

Try finding a client that does not exist, and I get the following result, which I believe is expected.

However, when I try to find an existing client again, e.g. Alex, I was told that there is no client in the contact list to find

In this case, user has to list all the client again before he can do the find. Not sure if this is the expected behavior. And this behavior is not mentioned in the UG.

Filtering client by age does not work as expected

The filter did not filter out the correct clients by age, the issue with sorting seems to persist here (after performing a sort operation, many functionalities do not work as expected).

UG broken links

The four links are broken. I've also inspected the UG source file, it looks like you have put down id for the corresponding titles but forgot to link it with the actual text.

Cannot filter client by birthday month

The given example command filterClients birtMonth op/lesser v/march is not usable, although I try to change the month input value to other values. And no message is given for why the input is invalid.

Messy notations in the class diagram for Model

The notations here are clustered here, making it a bit hard to read.

DG is not updated to matched the actual implementation

This sequence diagram does not match the actual code base. For example, the deletePerson method I believe should be deleteClient

Same issue for the diagram below

Duplicate client entries might go unnoticed

Problem: User is able to add two similar client data entries with the same name (with one being lower case and the other being proper upper case) and same data, as shown in the picture below

Steps to reproduce:

Execute the command

addClient n/John Doe p/98765432 e/[email protected] a/311 Clementi Ave 2 #02-25 b/21-03-1999 lc/21-03-2022 21:03

and

addClient n/john doe p/98765432 e/[email protected] a/311 Clementi Ave 2 #02-25 b/21-03-1999 lc/21-03-2022 21:03

Expected:

The application gives some warning about possible duplication.

Actual:

The client is successfully added.

This might cause inconvenience as the client list gets longer and user is not aware of such duplication, since the two upper case and lower case names are likely to refer to the same person.

Command name could be shorter for faster typing

The command names could be shortened so that fast typists can perform the task more quickly. E.g. editClient could be editC

Sorting cannot be reset by 'clients' command

Although mentioned in the user guide, the application does not reset the filter after issuing clients command.

Special symbol not allowed in client name

Client names containing s/o cannot be added, which can cause problems since this is an app for financial advisor, it would be important to record the client's legal name.

DummyTest

No details provided by bug reporter.

Important terms missing in the glossary in DG

Probably it would be good to explain what a policy is in this section.

Missing command in UG command summary

These 2 commands are not listed in the command summary section.

findClient command stops working after performing a sort on client attributes

The findClient command does not work anymore after a sort command is executed.

Steps to reproduce

• Do a sortClients numPolicies
• Then perform a findClient command

The application still lists out all clients, which causes inconvenience if the client list is long. To get rid of this, user has to restart the application.