Giter Site home page Giter Site logo

Comments (5)

HackbrettXXX avatar HackbrettXXX commented on May 27, 2024 1

I decided to use a "top down"/state approach where all inheritable attributes are passed to child nodes and overwritten when the child nodes specify the respective attributes themselves. Seems to be clearer to me and attributes don't have to be read several times.

from svg2pdf.js.

yGuy avatar yGuy commented on May 27, 2024 1

We're currently doing a round of bug fixing and will release a new build sometime in the next two weeks.

from svg2pdf.js.

yGuy avatar yGuy commented on May 27, 2024

Spec: https://www.w3.org/TR/SVG/painting.html#InheritanceOfPaintingProperties

from svg2pdf.js.

yGuy avatar yGuy commented on May 27, 2024

We should improve the code in https://github.com/yWorks/svg2pdf.js/blob/master/src/svg2pdf.js#L137 to walk upwards in the node element hierarchy to find the value if none is specified locally. This should only be done for inheritable attributes, though.

from svg2pdf.js.

TorsteinHonsi avatar TorsteinHonsi commented on May 27, 2024

Thanks so much! Will you build a new release or will you add more fixes first?

from svg2pdf.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.