zaherqasqas/hyf-javascript2

hyf-javascript2's Issues

Book Cover object not created

You were supposed to create an object having 'bookID' as the key and the source of the book cover as the value, then you had to access that object using the 'bookID' and set the source of the img tag to the value in the object. So, if the object having the image sources of book covers was 'bookCoverSource', then this is how you code would differ:

Your version:

hyf-javascript2/hyf-javascript2/Week1/script.js

Lines 27 to 29 in 02793b5

	img.setAttribute("src", "http://via.placeholder.com/100X100");
	img.setAttribute("id", book);
	img.setAttribute("alt", info.title + " photo")

Correct Version:
img.setAttribute("src", bookCoverSource[book]);
img.setAttribute("id", book);
img.setAttribute("alt", info.title + " photo")

No HTML or CSS files!

You forgot to put HTML and CSS files in the repository, can you please update the repository with the same?

Image should not exist in the H1 tag, the title should be in H1

Instead of adding the title directly to the li tag, you should have added it to the h1 tag. Also, the cover image of the book should not be in h1 tag, it should be inside the li tag.

hyf-javascript2/hyf-javascript2/Week1/script.js

Lines 33 to 37 in 02793b5

	li.innerText = info.title;
	p.innerText = info.language;
	div.innerText = info.author;
	h1.appendChild(img);