zatkiller/pe

pe's Issues

Incorrect use case for request help

There is a missing in the MSS of request help use case, which is JJIMY software redirects the user to the web version of the User guide.

Add order command fails on quantity 0

When quantity for a dish is specified as 0, the command throws an error message. However 0 is a valid number for a quantity. Error message does not capture it either as the message is "Non-negative integer must be specified" when integer is a non-negative integer

Command: order add n/hello dt/2020-02-27 d/1 q/0

Expected: Command to be valid

Actual: Error message shown "Non-negative integer must be specified"

Screenshot:

No matching shopping list features in UG

There is no feature in the app that allows the adding and removing of tasks from a shopping list. However, it is stated as user stories under the DG

Invalid email address on add customer allowed

[email protected] and [email protected] is not a valid email address but command is successful

Commands:

• customer add n/Alan Tan p/81236789 e/[email protected] a/21 Lower Kent Ridge
• customer add n/Alan Tan p/81236789 e/[email protected] a/21 Lower Kent Ridge

Expected: Invalid email address error mesage

Actual: Command is successful

Missing edit ingredient user story

DG has no user story which is about editing or changing the quantity of the ingredients, even though there is a feature to edit the ingredient and decrease the ingredient quantity

User stories regarding ingredients:

Typo in UG

No details provided.

Feature list indicates 'Mark order as completed' while actual header is 'Mark order as complete'. Believe there's is a typo and should be completed

Feature List:

Actual Header:

Invalid date allowed for add order command

Invalid date of 31 Feb allowed

Command: order add n/1 dt/31-02-2021 18:30 d/1 q/1

Expected: Invalid date error message:

Actual: Order added with date 28-02-2021

Command:

Result:

Traces of AB3 found

Log file still named after addressbook. Traces of AB3 should be removed now that the app has been renamed to JJIMY

Incorrect error message for invalid time

Invalid datetime value throws invalid datetime format error message instead of invalid datetime value
when timing of 18:70 is used. Still adheres to DD-MM-YYYY -HH:MM format.

Command: order add n/2 dt/14-02-2021 18:70 d/1 q/1 d/3 q/1

Expected: Expected error message like "Invalid datetime / invalid time"

Actual: "Invalid datetime format" error message

Test Catcher 2

Testing before PE 2

Invalid quantity allowed when editing data files

Editing ingredientbook.json quantity value to -100 is reflected in the UI even though it is an invalid value for quantity. Ideally, the app should throw an error but the UI reflects it an nothing happens

ingredientbook.json:

UI:

Invalid name on add customer successful

Invalid name of Alan T\nan used. However command is successful instead of error message

Command: customer add n/Alan T\nan p/81236789 e/[email protected] a/21 Lower Kent Ridge

Expected: Invalid name error message

Actual: Successfully added person

Invalid time for add order allowed

Timing specified for midnight should be 00:00. However when 24:00 value is used as timing, command is successful and adds the order as the following day

Command: order add n/1 dt/14-02-2021 24:00 d/1 q/1 d/3 q/1

Expected: Invalid time value

Actual: Command is sucessful

Command with datetime of 14-02-2021:

Order added as 15 Feb 00:00

Test CATcher desktop sdafsf

Test

asfsaf

Invalid dish price allowed when editing data file

Editing the dishbook.json file price to a negative double is allowed. Here, I went to the dishbook.json file and edited the price to be -11.5, which is reflected in the app. Ideally, app should throw an error that there is an invalid price but the negative price is allowed

dishbook.json:

UI:

Quantity error message incorrect

Command: inventory decrease 6 q/2

When trying to decrease quantity below 0, error message received is "The quantity entered is invalid, please enter a positive number only!". However, the quantity input is valid since 2 is a positive number.

Expected: Error message where quantity cannot go below 0

Actual: Error message - "The quantity entered is invalid, please enter a positive number only!"

Example for valid datetime format can be better

UG specifies datetime format as DD-MM-YYYY HH:MM format. However the example given is in the DD-MM-YYYY format. While this may be valid, I think a better example using the full DD-MM-YYYY HH:MM format should be used for a clearer demonstration

Missing edit dishes user story in DG

In the user guide, there is are features to edit the dish information. However under the user stories, there is no such user story about these features. Only add and remove dishes are present

UG example and result does not match for add customer

Add customer example does not specify any tags, but the example result given specifies that a tag of "Gluten Allergy" is added

DG navigation link not working

Clicking on Setting up, getting started in the table of content of the PDF does not navigate me to that section. However, it does on the Developer Guide website

Grammar mistake in UG

I believe it should be "an audio indicator" instead of just "audio indicator"

Duplicate user stories in DG of add dishes

No details provided.

UG example cut off

Many of the UG examples here are cut off, does not show full command format. User will be unable to know the full command format to use the command correctly

Wrong error message for find ingredient

Using a negative value for the quantity throws an invalid command format error message when it should be an invalid quantity value

Command: inventory find n/tomato q/-1

Expected: Invalid quantity error message

Actual: Invalid command format error message

Error message: