zedrichu/auth-rbac-system

Implementation of an RMI session-based authentication and role access control system using Client-Server architecture

💫 About My Interest Areas and Familiar Tools

💻 Programming Languages

💯 Software Engineering Frameworks

🌐 Web Development

♾️ DevOps Tech Stack

⚜️ Quantum Computing

       

📇 Databases

🤖 Artificial Intelligence & Deep Learning & Machine Learning

🔧 Other Technical Tools

📊 GitHub Stats:

---

auth-rbac-system's Issues

Move CLIMenu to Client package

It's the scope of the client application

Create Database config object in Server package to not store DB credentials in the class source code

SessionManager.clearExpired() removes 'young' tokens

private void clearExpired() {
        activeTokens.entrySet().removeIf((x) ->
                x.getValue().getStartTime().until(LocalDateTime.now(),
                ChronoUnit.MINUTES) < TTL_MINUTES);
}

should removeIf(... > TTL_MINUTES instead!

IPrinterService methods should log to file/return String to user

There is currently no logging or console outputting.

Suggestion: Printer methods return String that is displayed in the client's console.

SessionManager.validateSession() always returns false

In SessionManager.loginSingleUse():

if (authResult == ResponseCode.OK) {
            session = issueToken(userId);
            session.singleUse = true;
}

but when validating session:

public boolean validateSession(Session session) throws RemoteException {
        // ...
        if (session.singleUse) activeTokens.remove(session.getId()); // Always removes the token (singleUse is true if the user logged in)
        return activeTokens.containsKey(session.getId());  // And thus this is always false so no PrinterServant method can be executed
}

Client is authenticated more times than necessary

Client.connect(IAppServer app) calls Client.authenticate() MAX_RETRIES times even if they have already been authenticated at some previous iteration of the loop.

IPrinterService.start() and stop() should start/stop print server (not a job)

Assignment file:
start(); // starts the print server
stop(); // stops the print server

Our code:

public void start(Session session) throws RemoteException {
        if (!sessionManager.validateSession(session)) return;
        System.out.println("|> Printer job started");
    }

public void stop(Session session) throws RemoteException {
    if (!sessionManager.validateSession(session)) return;
    System.out.println("|> Printer job stopped");
}

Small renaming from Token to Session

public class SessionManager extends UnicastRemoteObject implements ISessionValidator, ISessionProvider {

    private final Authenticator authenticator;
    private static final int TTL_MINUTES = 60;
    private final HashMap<UUID, Session> activeTokens;

activeTokens should be renamed to: activeSessions..