zeel01/pin-fixer

Make map pins remain the same size regardless of zoom level.

pin-fixer's Issues

Show Pins Above Fog and Lock Pins on Other Layers conflict

Environment:

core: 0.7.8
system: SWS 0.4
pin-fixer: 1.0.4
✔️ Reproduces with only pin-fixer active.

Setup:

Have a world with two scenes.
One scene has pins and fog exploration enabled.
Place a token with vision down.
Give this scene both of these options:

• Lock Pins on other Layers
• Show Pins above fog

Repro Steps:

1. On the scene with pins and fog, select the token with vision. (note that pins appear above fog correctly)
2. Navigate to the other scene.
3. Navigate back
4. Select the token with vision again.

Expected: Pins should be visible above fog.
Actual: Pins are not visible above fog after step 4.

Notes

This only happens when both mentioned settings are set. Workaround is to not lock pins if you want them above fog.

When Module is active, scenes can

"Show Map Pins Above Fog" problem (version 9)

While Show Map Pins Above Fog is active, hovering over any pin on top of fog makes it disappear. It should not.
Zooming in and out makes them reappear. But they disappear again, if hovering over the pins once more.

Pins are being shown disregarding permissions

Pins that are being "unhidden" disregarding scale, also disregard permissions.

[incompatibility] Levels

Not a huge issue, but when using the levels module, when scrolling it brings all of the map notes to the current level regardless of which level they are placed on. Mousing over a note will move it back to its intended layer/level, but its sort of annoying having the pins all crowding ontop of each other

Feature Request(s): Saveable Defaults, apply to all

Love the module, but setting it per scene is annoying, especially when you're importing many scenes at once from a premium content module. Could we please get something in module settings that can change the initial configuration, and either a button in the settings area or a macro to apply that to all scenes?

bad default setting

the zoom ceiling is defaulting to 5 but does not allow anything to be saved if greater than 3... I think it might have taken it from "pan/zoom options setting, which can be greater

Console error: foundry.js:319 TypeError: Cannot read properties of null (reading 'data')

When loading the world:

[Request] Scale per Pin

Greetings!

I was wondering if you could implement this scaling per pin on a scene. I want this because I am producing a world map full of journal notes, but would rather only see specific journal notes based on zoom. For example, on a world map I might want to see the pin that represents the country, instead of every country/province/town. With this feature, I'd be able to set the country map pins to be visible when fully zoomed out, and then have the town pins visible when zoomed in. Additionally, I need this solution for a module I'm working on that imports World Maps from Azgaar's Fantasy Map Generator.

I am also open to making a PR for this, so just let me know.

Thanks,
Ethck

Pin Labels not showing on Hover or not at all.

1.) If I don't have "Always Show Pin Label" checked, I don't see the pin labels when I hover over the pin with the cursor.

2.) Pins don't always appear. Sometimes they appear when I click on a token... but then vanish when I resize the screen.

Tested with no other mods active.

Show Pins above Fog not working for players

Environment:

core: 0.7.8
system: SWS 0.4
pin-fixer: 1.0.4
✔️ Reproduces with only pin-fixer active.

Setup:

Have a world with two scenes.
One scene has pins and fog exploration enabled.
Place a token with vision down.
Give this scene both of these options:

• Show Pins above fog
  Log in with a Player user who can see through the token with vision's token.
  Set this player's "Toggle notes display" to "always on"

Repro Steps:

1. On the scene with pins and fog note that pins appear above fog correctly.
2. Navigate to the other scene.
3. Navigate back

Expected: Pins should be visible above fog.
Actual: Pins are not visible above fog after step 3.

Notes

Only happens for Player Accounts, similar to #5, probably related.

If the player selects the Pins Tool, all pins become visible.

The values filled in when the scene config renders are the values of the *active* scene rather than the scene being configured.

When the scene config renders and HTML is injected, the values set in the form are based on the value in the currently active scene, rather than being the values stored in the scene currently being edited.

Configure distance between Icon and Text

Would be great to be able to configure this distance, as with smaller textsizes, the text is quite far away from the Journal Note Icon.

Pin is being hidden on the pan canvas

As a player the pin is hidden when panning or zooming on the canvas. That problem does not happens as a GM.

Module version: 1.2.2
Foundry version: V10

Pins that are not linked to jounal entries are rendered invisible to everyone, including th GM.

Whenever you have a map note which is not linked to any journal entry (for example, the entry was deleted, or the map pin is a copy of another similar pin), it becomes invisible and can not be accessed.
The vanilla behaviour for such pins is to make them visible for everyone (see foundry.js@42651: Note.refresh()).

TypeError: Cannot read properties of null (reading 'flags')

Error showed up after migrating from v9 to v10.

When Module is active, scenes can't be saved

When the module is enabled, it's not possible to change or create a new scene, since the "save" button loses its function. You can click it once, nothing will happen. after that there's nothing you can do except close the window and deactivate the module to start anew.

Feature Suggestion: Allow Notes to be on top of Fog layer for a given scene.

This is super useful for image-fog use case:
Setting canvas.notes.zIndex = 300 will pull the notes layer above all currently known fog layers.

Example:

Duplicates Image Fog issue #16

[Feature Request] Update for v11

Incompatibility with Token Magic FX

Running Token Magic FX and Pin Fix at the same time causes journal entries on map to be unable be dragged.

Pin Labels be above tokens but below Fog

Was checking out whether it was possible to make tokens appear below the pin labels on mouse over.
Right now the work around is to use PINs above Fog layer, but that goes -too- far.
Perhaps an option to be able to set labels above tokens would be nice, to avoid this (without sacrificing fog):

Pins vanish for PCS if map zoomed

For players, pins vanish of map is zoomed in or out. They re-appear when the player token is moved.

Chrome (forge)
Foundry v10
Pin Fixer 1.2.2