The combine from zefer

remove extra charset declarations from css-Chrome & Safari bug

I'm in process of integrating combine and it is a great tool! All of my css files have "@charset "utf-8"; declaration. Combined files keep multiple declarations as each file is added to combined file.

So far IE 7 & 8 and FF3.6 seem to ignore the extra declarations but Chrome and Safari ( on PC) don't like the first rule after each new declaration in middle of file. I can manually remove them but I also built a flag to write full links out for each css file for debugging purposes as well.

Any feedback greatly appreciated

Error encoding JS files with UTF-8 encoding

Hi, I am having problems when trying to minify JS files that contain UTF-8 using JSMin from your combine.jar.

I've created a standalone version of your compressJsWithJSMin() method rather than the whole combine.cfc.

As a simple test I have the string "This is a test Франция" which results in the output "This is a test $@0=F8O"

I've tried setting a Charset string on the output toString() method but it makes no difference.

I realise that this isn't strictly an issue with your combine package but I hope you can forgive me for asking for help here.

I have a simple standalone example that demonstrates the issue;

<cfcontent type="text/html; charset=utf-8" />
<cfprocessingdirective pageEncoding="utf-8"/>
<html>
    <head>
        <title>JSMin UTF-8 test</title>
    </head>
    <body>

<cftry>
    <cfscript>
        testString = "This is a test Франция";
        joInput = createObject("java","java.io.StringReader").init(testString);
        joOutput = createObject("java","java.io.ByteArrayOutputStream").init();
        javaloader  = createObject('component','components.javaloader.JavaLoader').init([application.settings.localdir & "components/jsmin/combine.jar"]);
        jJSMin = javaloader.create("com.magnoliabox.jsmin.JSMin").init(joInput, joOutput);
        jJSMin.jsmin();
    </cfscript>

<cfoutput><pre>
TestString:"#testString#"
Native:"#joOutput.toString()#"
UTF-8:"#joOutput.toString("UTF-8")#"
ISO-8859-1:"#joOutput.toString("ISO-8859-1")#"
US-ASCII:"#joOutput.toString("US-ASCII")#"
</pre></cfoutput>

    <cfset joInput.close() />
    <cfset joOutput.close() />

    <cfcatch>
        <cfdump var="#cfcatch#" />
    </cfcatch>
</cftry>

</body>
</html>

@media queries.

I noticed any CSS with a media query was failing. After grabbing the latest yuicompressor things started working again.

Perhaps its time to update your libraries? :D

zefer / combine Goto Github PK

combine's People

Contributors

Stargazers

Watchers

Forkers

combine's Issues

remove extra charset declarations from css-Chrome & Safari bug

Error encoding JS files with UTF-8 encoding

@media queries.

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent