zenaton/zenaton-ruby

💎 Ruby gem to run and orchestrate background jobs with Zenaton Workflow Engine

zenaton-ruby's Issues

Being able to load ActiveRecord after a Rake task execution

Currently, it's possible to do it by using rails runner

Support Ruby language in serialization

The serializer in ruby converts symbols to strings because symbols are ruby specific and cannot be represented in json.

Single Task Dispatch Feature

For details have a look here => zenaton/zenaton-php#15

Add Active Job support

Use of `Wait` class outside a workflow should thrown an exception

To be clear, the test should be that the class is used within a workflow - NOT that it is processed by an agent. So locally executing a workflow is still perfectly fine.

A specific Zenaton error should be thrown and documented.

Use of `execute` method outside a workflow should thrown an exception

Expected behavior of execute method does make sense only within a workflow.

To be clear, the test should be that the method is used within a workflow - NOT that it is processed by an agent. So locally executing a workflow is still perfectly fine.

A specific Zenaton error should be thrown and documented.

Update documentation

There is one invalid @return value in the existing docs and some methods are undocumented (mostly from the refinements PR)

➜ yard doc
[warn]: Invalid tag format for @return in file `lib/zenaton/traits/with_timestamp.rb` near line 28
Files:          36
Modules:        12 (    0 undocumented)
Classes:        36 (    0 undocumented)
Constants:      38 (    0 undocumented)
Attributes:      7 (    0 undocumented)
Methods:        67 (   13 undocumented)
 91.88% documented

Hashes are always deserialized into string-keys hashes

As a user of this gem
When my workflow is dispatched (vs executed) and I have properties that are hashes with atoms as keys
Then I expect to still be able to access this hash using atoms

Add the ability to run recurrent task & workflow

Correct the behaviour of Event Subclasses in the Ruby Library

As known for some times, the when subclassing and Event class, the child Event is not handled properly by Zenaton changes has to be done, in coordination between the engine, agent and client libraries.

For more details please check:

zenaton/rfcs#19

Make to sure to encode query parameters in HTTP call

eg with the workflow id:

[email protected] the kill does not work.

Weekday and DayOfMonth methods should wait when the day provided is today

Expected Behavior:

per the discussion with @geomagilles:

if we are on Monday, 11am on the 23rd of the month. Then:

.Monday(1) should wait until next Monday at 11am
.Monday(1).At("9") should wait until next Monday at 9am
.Monday(1).At("13") should wait 2 hours only
.DayOfMonth(23) should wait for one month
.DayOfMonth(23).At("13") should wait for only 2 hours

Problem:

Currently, if today is a Monday, when calling Zenaton::Tasks::Wait.new.monday you don't actually wait until the next Monday, and the wait terminates immediately.

We have the same issue with the dayOfMonth method. If it's the 23rd and you call Zenaton::Tasks::Wait.new.day_of_month(23) you won't wait until the next month, but instead the wait will terminate immediately.

Specifically, I believe the two problematic lines are these:

zenaton-ruby/lib/zenaton/traits/with_timestamp.rb

Line 102 in 5c19799

now_dup += 1.month if now > now_dup

zenaton-ruby/lib/zenaton/traits/with_timestamp.rb

Line 69 in 5c19799

value.times { |_n| now_dup = now_dup.next_occurring(day) }

(note: I don't actually understand the ruby in the second link here, so I cannot confirm if the ruby library has the problem with weekdays that the other libraries do)

Fix:

See zenaton/zenaton-go#7 for the fix in the go library.