zhiburt/conpty

A Rust abstraction over ConPTY https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/

conpty's Issues

cant working on windows subsystem

I discovered conpty cant working when set #![windows_subsystem = "windows"]. the following code will get the bug。

Error Message : Windows error : Invalid handle

#![windows_subsystem = "windows"]

use std::io::Write;
fn main() {
    let proc = match conpty::spawn("cmd.exe"){
        Ok(p) => p,
        Err(e) => {
            let mut f = std::fs::File::create("error.txt").unwrap();
            f.write_all(format!("{}" ,e).as_bytes()).unwrap();
            f.flush().unwrap();
            return;
        },
    };
    proc.wait(None).unwrap();
}

Create a custom Error type or use io::Error

sticking with windows::Error might be not good decision

`ProcAttr::args()` has no effect

If a user sets the arguments for a program via ProcAttr::args() or ProcAttr::arg(), the arguments will not be used when spawning the process. This affects usage of expectrl, as passing a Command with arguments to Session::spawn() will work on Unix but not on Windows.

Async support (tokio runtime)?

Any chance the handles returned by Command::stdout() could be made async-capable? I spent a good deal of time seeing if I could somehow get them wrapped in a way that would allow tokio's AsyncReadBufExt-enabled structs to consume them, but my knowledge of futures internals is limited and it seems like conpty might be using a slightly different set of underlying types than tokio expects on Windows (HANDLE seems to be defined differently for some reason?)

hide non blocking functions behind feature `util`?

There's no reason to provide these function by default.