Giter Site home page Giter Site logo

zjays / nightingale-gridview Goto Github PK

View Code? Open in Web Editor NEW
1.0 2.0 0.0 188 KB

Gridview Addon for Nightingale - Addon originally developed for Songbird by "JohnM". I don't fully understand how this code works and not willing to spend too much time figuring it out, so if somebody else wants to fix issues or add new features, feel free to create pull requests!

Home Page: http://wiki.getnightingale.com/doku.php?id=add-ons#grid_view

JavaScript 90.31% CSS 9.69%

nightingale-gridview's People

Contributors

zjays avatar

Stargazers

Bence Szalai avatar

Watchers

James Cloos avatar  avatar

nightingale-gridview's Issues

Playlist is filtered based on Artist instead of Album Artist

Setup:
Nightingale 1.12.2a, Build 2455 (20140613141836) (but 1.12.1 behaves the same)
GridView 0.5.2
Preferences / Grid View / Ignore Album Artist property is unselected

Problem:
Tracks are not being displayed in the playlist when selecting an Artist in the GridView if Artist is not the same as Album Artist.

Background:
Albums having multiple different Artists may have an uniform Album Artist in order to prevent media players to think there are multiple Albums with the same Album Title from different Artists. If the Album Artist is configured and configured to be the same across all tracks on an Album, the tracks can have different Artists, still handled as one Album.

Details:
There is a problem in the way GridView filters the playlist to show the Tracks related to a given Artist when an Artist is selected in the Grid.
Instead of filtering the playlist to include every item with Album Artist matching the selection, it actually filters the playlist to show Tracks where Artist matches the selection. As a result only those Tracks are shown, which have the same Album Artist as Artist. If Artist is different from Album Artist the Track cannot be accessed in this view.

Example:
Lets say we have 2 tracks in a playlist:
1.) Artist: "Artist1 feat. Artist2"; Album: "GoodLP"; Album Artist: "Artist1"
2.) Artist: "Artist1"; Album: "GoodLP"; Album Artist: "Artist1"

Expected behaviour:
GridView displays an item with title "Artist1" and when this item is selected the playlist shows both tracks.

Actual behaviour:
GridView displays an item with title "Artist1" and when this item is selected the playlist only shows Track 2, where Album Artist is the same as Artist.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.