Switch to Pretty Upstream

[mcDevnagh]

Switch to Pretty Upstream

[tjex]

@mcDevnagh any further thoughts on this? (I'm also back from holidays, feeling refreshed. Lets goooo 💪)

[tjex]

@mcDevnagh I had a quick look at this and our fork has one commit from Mickael, which adds some pretty printing for time.Time. I tested some failing tests with kr/pretty and couldn't spot any difference. But I'm sure I must've just missed where this commit is being useful.

Considering the upstream kr/pretty doesn't have any implementation for time.Time formatting (so it's not a case where Mickael committed to his branch first in order to make a PR upstream), perhaps it's better to stay with our fork and look at merging upstream instead?

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 5 days.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 5 days.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 5 days.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.

[mcDevnagh]

I wouldn't expect https://github.com/kr/pretty to accept, seeing that it hasn't seen a commit in 2 years, and its issues/PRs are ignored. Mickael's fork was added here— 0e8ae93 —so these tests would be the pertinent ones: https://github.com/zk-org/zk/blob/main/internal/adapter/sqlite/note_dao_test.go . Until kr/pretty sees movement again, I think we should stick with our own fork. If that project is dead, there is not a compelling reason to switch back to it.