`convert_background.py` fails on `menu_file_selection_commands.tilemap.encoded`

[KelseyHigham]

`convert_background.py` fails on `menu_file_selection_commands.tilemap.encoded`

[daid]

note, replacing while data[idx] != 0x00: with while idx < len(data) and data[idx] != 0x00: will most likely fix the export, but on import it will not produce the right file, as the import will add the nul termination.

[kemenaran]

Nice catch. I'm a bit busy with real life those weeks, but if you feel you can make a patch out of it, I'll be glad to review it :)

[KelseyHigham]

maybe convert_background.py could accept a --no_null_terminator parameter, mandatory for both decode and encode for that file.

if you try to decode menu_file_selection_commands.tilemap.encoded without the parameter, it can give you an error, and tell you to provide the parameter for both encode and decode.

I think that should catch most human errors.

[kemenaran]

That sounds definitely like a good fix 👍

I'll see if I have some time for this, but otherwise feel free to hack something and submit it.

[KelseyHigham]

note for anyone who gets bit by this in the meantime –
you can replace the contents of menu_file_selection_commands.tilemap.encoded with this:
99e20f 7e7e7e7e 0411001204 7e7e 020e0f18 7e
which basically says:
[info] ________ E R A S E ____ C O P Y __
ignore the first 3 bytes, and edit the rest normally.