zlikavac32/php-enum

Better PHP enum support

php-enum's Issues

implement Ds\Hashable

After reading https://medium.com/@rtheunissen/efficient-data-structures-for-php-7-9dda7af674cd I've been using the Ds\Map and Ds\Set collections in my code. For an object to be usable as a key in Ds\Map and to ensure uniqueness in Ds\Set, the object's class needs to implement Ds\Hashable.

Would you consider implementing Hashable in Enum?

The current workaround is to use $enum->name() as a map key, but this is suboptimal, and sets cannot be determined uniqueness.

I can create a PR if you'd like.

Why \Zlikavac32\Enum\Enum::enumerate isn't abstract method?

IMO it would be better if \Zlikavac32\Enum\Enum::enumerate was an abstract method, so that every class extending it has to implement the method, instead of throwing an exception on parent method call manually?

Edit:

Now I see that extension class also has to be an abstract class, so abstract method won't do much.

获取PHPDoc的正则在解析的时候会出现\r，建议正则修改！

$regex = '/@method\s+static\s+[^\s]+\s+(.+)\s*\r(?:\(\))?/';