zoj613/htnorm

Fast and Exact Simulation of Hyperplane-Truncated Multivariate Normal Distributions, with C, Python and R interfaces.

htnorm's Issues

BUILD: Make the R package installable on Windows

Last I checked it wasn't.

BUG: Exceptions are not explicitly raised in python when validating output.

htnorm/pyhtnorm/_htnorm.pyx

Lines 98 to 109 in ef1f2e4

	cdef inline void validate_return_info(int info):
	if info == HTNORM_ALLOC_ERROR:
	raise MemoryError("Not enough memory to allocate resources.")
	elif info < 0:
	raise ValueError("Possible illegal value in one of the inputs.")
	elif info > 0:
	raise ValueError(
	f"""Either the leading minor of the {info}'th order is not
	positive definite (meaning the covariance matrix is also not
	positive definite), or factorization of one of the inputs
	returned a `U` with a zero in the {info}'th diagonal."""
	)

Since this cython function has void return type, the raised exception is not propagated properly and thus gets treated as a warning.

To remedy this, the function should return an int. A value of zero when everything checks out and probably a -1 otherwise.

BUILD: Add basic CI

Error installing on linux via pip

Hi everyone,
i tried to install the package via pip. But i get the following error :

           error: Command "gcc -pthread -B /home/dingeldein/anaconda3/envs/cryo_sbi/compiler_compat -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -fPIC -O2 -isystem /home/dingeldein/anaconda3/envs/cryo_sbi/include -fPIC -O2 -isystem /home/dingeldein/anaconda3/envs/cryo_sbi/include -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -DSCIPY_MKL_H -DHAVE_CBLAS -I/usr/local/include -I/usr/include -I/home/dingeldein/anaconda3/envs/cryo_sbi/include -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/home/dingeldein/anaconda3/envs/cryo_sbi/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-cpython-310/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-cpython-310/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o.d" failed with exit status 1
           [end of output]
     
       note: This error originates from a subprocess, and is likely not a problem with pip.
       ERROR: Failed building wheel for numpy
     Failed to build numpy
     ERROR: Could not build wheels for numpy, which is required to install pyproject.toml-based projects
     [end of output]
 
 note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

on Ubuntu 22.04.1 LTS