zorab47/active_admin-subnav

Enhanced sub-navigation for nested ActiveAdmin resources

active_admin-subnav's Issues

Add documentation and examples to README

Depreciation Warning for newer Sprockets

Using Arbre, I get the following depreciation warning after upgrading to sprockets 3.6.3 and sprockets-rails 3.1.1:

DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /var/lib/gems/2.1.0/gems/active_admin-subnav-0.0.1/app/assets/stylesheets/active_admin/subnav.css.scss to /var/lib/gems/2.1.0/gems/active_admin-subnav-0.0.1/app/assets/st
ylesheets/active_admin/subnav.scss

Seems like a simple rename should do the trick, but I wanted to bring it to your attention.

[discussion] update to recent activeadmin features

Hello @zorab47 , hope you're doing well and someday this gem will be merged to activeadmin.
I just wanted to notify you about next changes that can reflect to this gem.

1. about pages
   pages are supports belongs_to, so there is no reason to skip pages from active_admin-subnav take a look activeadmin/activeadmin#4759

2. about extra setup

# Provide access to the parent resource record: Site.
# Without this extra setup the parent record will not be accessible. Any
# calls to `#parent` will return the Arbre parent element and not the
# ActiveAdmin resource.

can you explain why this needed ? and why it is not possible to use helpers.parent in arbre https://github.com/Fivell/activeadmin/blob/05877d45d464d1911ca7d53072c81516c7614281/features/registering_pages.feature#L181

3. about controller hack

https://github.com/zorab47/active_admin-subnav/blob/master/lib/active_admin/subnav/extensions/base_controller.rb#L11

Can you please explain why this needed, maybe we'll find more clean workaround for this

Thanks

Add before/after images to README

Add a chang log

belongs_to 'Place holder' ?

Currently if you make 'Parent' in active_admin menu, it'll be a place holder (not linked to a page). I want to do the same with sub-menu, here's an example:

Main Menu (Place Holder)

• Sub Menu 1 (Link)
• Sub Menu 2 (Place Holder)
  -- Sub Sub Menu 1 (Link)
  -- Sub Sub Menu 2 (Link)